All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: lee@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	bcousson@baylibre.com, tony@atomide.com, andreas@kemnade.info,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: [PATCH 5/6] mfd: twl4030-power: accept standard property for power controller
Date: Sat, 25 Nov 2023 10:29:37 +0100	[thread overview]
Message-ID: <20231125092938.16535-6-andreas@kemnade.info> (raw)
In-Reply-To: <20231125092938.16535-1-andreas@kemnade.info>

Instead of only accepting the ti specific properties accept also
the standard property. For uniformity, search in the parent node
for the tag. The code for powering of is also isolated from the
rest in this file. So it is a pure Linux design decision to put it
here.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 drivers/mfd/twl4030-power.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
index e35b0f788c504..3ef892e63b88f 100644
--- a/drivers/mfd/twl4030-power.c
+++ b/drivers/mfd/twl4030-power.c
@@ -686,6 +686,9 @@ static bool twl4030_power_use_poweroff(const struct twl4030_power_data *pdata,
 	if (of_property_read_bool(node, "ti,use_poweroff"))
 		return true;
 
+	if (of_device_is_system_power_controller(node->parent))
+		return true;
+
 	return false;
 }
 
-- 
2.39.2


  parent reply	other threads:[~2023-11-25  9:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-25  9:29 [PATCH 0/6] mfd: twl: system-power-controller Andreas Kemnade
2023-11-25  9:29 ` [PATCH 1/6] dt-bindings: mfd: ti,twl: Document system-power-controller Andreas Kemnade
2023-11-25 11:46   ` Conor Dooley
2023-11-25  9:29 ` [PATCH 2/6] twl-core: add power off implementation for twl603x Andreas Kemnade
2023-11-25 15:13   ` kernel test robot
2023-11-25 20:00   ` kernel test robot
2023-11-26 23:32   ` kernel test robot
2023-11-25  9:29 ` [PATCH 3/6] ARM: dts: omap-embt2ws: system-power-controller for bt200 Andreas Kemnade
2023-11-25  9:29 ` [PATCH 4/6] ARM: dts: omap4-panda-common: Enable powering off the device Andreas Kemnade
2023-11-25  9:29 ` Andreas Kemnade [this message]
2023-11-25  9:29 ` [PATCH 6/6] ARM: dts: omap: gta04: standardize system-power-controller Andreas Kemnade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231125092938.16535-6-andreas@kemnade.info \
    --to=andreas@kemnade.info \
    --cc=bcousson@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.