Re: [PATCH RFC 7/7] treewide: sysctl: migrate proc_dointvec to proc_handler_new

From: kernel test robot <lkp@intel.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH RFC 7/7] treewide: sysctl: migrate proc_dointvec to proc_handler_new
Date: Sun, 26 Nov 2023 00:48:25 +0800	[thread overview]
Message-ID: <202311252331.C9ABVKC2-lkp@intel.com> (raw)
In-Reply-To: <20231125-const-sysctl-v1-7-5e881b0e0290@weissschuh.net>

Hi Thomas,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on 0f5cc96c367f2e780eb492cc9cab84e3b2ca88da]

url:    https://github.com/intel-lab-lkp/linux/commits/Thomas-Wei-schuh/sysctl-add-helper-sysctl_run_handler/20231125-205506
base:   0f5cc96c367f2e780eb492cc9cab84e3b2ca88da
patch link:    https://lore.kernel.org/r/20231125-const-sysctl-v1-7-5e881b0e0290%40weissschuh.net
patch subject: [PATCH RFC 7/7] treewide: sysctl: migrate proc_dointvec to proc_handler_new
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20231125/202311252331.C9ABVKC2-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231125/202311252331.C9ABVKC2-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311252331.C9ABVKC2-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/scsi/scsi_sysctl.c:20:27: error: initialization of 'int (*)(struct ctl_table *, int,  void *, size_t *, loff_t *)' {aka 'int (*)(struct ctl_table *, int,  void *, long unsigned int *, long long int *)'} from incompatible pointer type 'int (*)(const struct ctl_table *, int,  void *, size_t *, loff_t *)' {aka 'int (*)(const struct ctl_table *, int,  void *, long unsigned int *, long long int *)'} [-Werror=incompatible-pointer-types]
      20 |           .proc_handler = proc_dointvec },
         |                           ^~~~~~~~~~~~~
   drivers/scsi/scsi_sysctl.c:20:27: note: (near initialization for 'scsi_table[0].proc_handler')
   cc1: some warnings being treated as errors

vim +20 drivers/scsi/scsi_sysctl.c

^1da177e4c3f41 Linus Torvalds    2005-04-16  13  
^1da177e4c3f41 Linus Torvalds    2005-04-16  14  
592749e4d05fb6 Joe Perches       2014-06-06  15  static struct ctl_table scsi_table[] = {
894d2491153a9f Eric W. Biederman 2009-11-05  16  	{ .procname	= "logging_level",
^1da177e4c3f41 Linus Torvalds    2005-04-16  17  	  .data		= &scsi_logging_level,
^1da177e4c3f41 Linus Torvalds    2005-04-16  18  	  .maxlen	= sizeof(scsi_logging_level),
^1da177e4c3f41 Linus Torvalds    2005-04-16  19  	  .mode		= 0644,
6d4561110a3e9f Eric W. Biederman 2009-11-16 @20  	  .proc_handler	= proc_dointvec },
^1da177e4c3f41 Linus Torvalds    2005-04-16  21  };
^1da177e4c3f41 Linus Torvalds    2005-04-16  22  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki