From: Oleg Nesterov <oleg@redhat.com>
To: NeilBrown <neilb@suse.de>, Al Viro <viro@zeniv.linux.org.uk>
Cc: Christian Brauner <brauner@kernel.org>,
Jens Axboe <axboe@kernel.dk>,
Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH/RFC] core/nfsd: allow kernel threads to use task_work.
Date: Tue, 28 Nov 2023 15:20:18 +0100 [thread overview]
Message-ID: <20231128142018.GA24108@redhat.com> (raw)
In-Reply-To: <20231128140156.GC22743@redhat.com>
On 11/28, Oleg Nesterov wrote:
>
> On a related note... Neil, Al, et al, can you look at
>
> [PATCH 1/3] fput: don't abuse task_work_add() when possible
> https://lore.kernel.org/all/20150908171446.GA14589@redhat.com/
Cough... Now that I look at this 8 years old patch again I think
it is wrong, fput() can race with task_work_cancel() so it is not
safe to dereference the first pending work in theory :/
Oleg.
next prev parent reply other threads:[~2023-11-28 14:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 22:05 [PATCH/RFC] core/nfsd: allow kernel threads to use task_work NeilBrown
2023-11-27 22:30 ` Al Viro
2023-11-27 22:43 ` NeilBrown
2023-11-27 22:59 ` Chuck Lever
2023-11-28 0:16 ` NeilBrown
2023-11-28 1:37 ` Chuck Lever
2023-11-28 2:57 ` NeilBrown
2023-11-28 15:34 ` Chuck Lever
2023-11-30 17:50 ` Jeff Layton
2023-11-28 13:51 ` Christian Brauner
2023-11-28 14:15 ` Jeff Layton
2023-11-28 15:22 ` Chuck Lever
2023-11-28 23:31 ` NeilBrown
2023-11-28 23:20 ` NeilBrown
2023-11-29 11:43 ` Christian Brauner
2023-12-04 1:30 ` NeilBrown
2023-11-29 14:04 ` Chuck Lever
2023-11-30 17:47 ` Jeff Layton
2023-11-30 18:07 ` Chuck Lever
2023-11-30 18:33 ` Jeff Layton
2023-11-28 11:24 ` Christian Brauner
2023-11-28 13:52 ` Oleg Nesterov
2023-11-28 15:33 ` Christian Brauner
2023-11-28 16:59 ` Oleg Nesterov
2023-11-28 17:29 ` Oleg Nesterov
2023-11-28 23:40 ` NeilBrown
2023-11-29 11:38 ` Christian Brauner
2023-11-28 14:01 ` Oleg Nesterov
2023-11-28 14:20 ` Oleg Nesterov [this message]
2023-11-29 0:14 ` NeilBrown
2023-11-29 7:55 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128142018.GA24108@redhat.com \
--to=oleg@redhat.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=neilb@suse.de \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.