From: Eric Biggers <ebiggers@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH 0/4] crypto: Fix chaining support for stream ciphers (arc4 only for now)
Date: Wed, 29 Nov 2023 13:04:21 -0800 [thread overview]
Message-ID: <20231129210421.GD1174@sol.localdomain> (raw)
In-Reply-To: <ZWbZEnSPIP5aHydB@gondor.apana.org.au>
On Wed, Nov 29, 2023 at 02:24:18PM +0800, Herbert Xu wrote:
> On Mon, Nov 27, 2023 at 02:28:03PM -0800, Eric Biggers wrote:
> >
> > As far as I can tell, currently "chaining" is only implemented by CBC and CTR.
> > So this really seems like an issue in AF_ALG, not the skcipher API per se.
> > AF_ALG should not support splitting up encryption/decryption operations on
> > algorithms that don't support it.
>
> Yes I can see your view. But it really is only a very small number
> of algorithms (basically arc4 and chacha) that are currently broken
> in this way. CTS is similarly broken but for a different reason.
I don't think that's accurate. CBC and CTR are the only skciphers for which
this behavior is actually tested. Everything else, not just stream ciphers but
all other skciphers, can be assumed to be broken. Even when I added the tests
for "output IV" for CBC and CTR back in 2019 (because I perhaps
over-simplisticly just considered those to be missing tests), many
implementations failed and had to be fixed. So I think it's fair to say that
this is not really something that has ever actually been important or even
supported, despite what the intent of the algif_skcipher code may have been. We
could choose to onboard new algorithms to that convention one by one, but we'd
need to add the tests and fix everything failing them, which will be a lot.
- Eric
next prev parent reply other threads:[~2023-11-29 21:04 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 8:28 [PATCH 0/8] crypto: Add lskcipher API type Herbert Xu
2023-09-14 8:28 ` [PATCH 1/8] crypto: aead - Add crypto_has_aead Herbert Xu
2023-09-14 8:28 ` [PATCH 2/8] ipsec: Stop using crypto_has_alg Herbert Xu
2023-09-14 8:28 ` [PATCH 3/8] crypto: hash - Hide CRYPTO_ALG_TYPE_AHASH_MASK Herbert Xu
2023-09-14 8:28 ` [PATCH 4/8] crypto: skcipher - Add lskcipher Herbert Xu
2023-09-20 6:25 ` Eric Biggers
2023-09-21 4:32 ` Herbert Xu
2023-09-22 3:10 ` Eric Biggers
2023-11-17 5:19 ` Herbert Xu
2023-11-17 5:42 ` Eric Biggers
2023-11-17 9:07 ` Herbert Xu
2023-11-24 10:27 ` Herbert Xu
2023-11-27 22:28 ` Eric Biggers
2023-11-29 6:24 ` [PATCH 0/4] crypto: Fix chaining support for stream ciphers (arc4 only for now) Herbert Xu
2023-11-29 6:29 ` [PATCH 1/4] crypto: skcipher - Add internal state support Herbert Xu
2023-11-29 6:29 ` [PATCH 2/4] crypto: skcipher - Make use of internal state Herbert Xu
2023-11-29 6:29 ` [PATCH 3/4] crypto: arc4 - Add " Herbert Xu
2023-11-29 6:29 ` [PATCH 4/4] crypto: algif_skcipher - Fix stream cipher chaining Herbert Xu
2023-11-29 21:04 ` Eric Biggers [this message]
2023-11-30 2:17 ` [PATCH 0/4] crypto: Fix chaining support for stream ciphers (arc4 only for now) Herbert Xu
2023-11-30 9:55 ` [v2 PATCH " Herbert Xu
2023-11-30 9:56 ` [v2 PATCH 1/4] crypto: skcipher - Add internal state support Herbert Xu
2023-11-30 9:56 ` [v2 PATCH 2/4] crypto: skcipher - Make use of internal state Herbert Xu
2023-11-30 9:56 ` [v2 PATCH 3/4] crypto: arc4 - Add " Herbert Xu
2023-11-30 9:56 ` [v2 PATCH 4/4] crypto: algif_skcipher - Fix stream cipher chaining Herbert Xu
2023-12-02 3:49 ` [v3 PATCH 0/4] crypto: Fix chaining support for stream ciphers (arc4 only for now) Herbert Xu
2023-12-02 3:50 ` [v3 PATCH 1/4] crypto: skcipher - Add internal state support Herbert Xu
2023-12-02 3:50 ` [v3 PATCH 2/4] crypto: skcipher - Make use of internal state Herbert Xu
2023-12-02 3:50 ` [v3 PATCH 3/4] crypto: arc4 - Add " Herbert Xu
2023-12-02 3:50 ` [v3 PATCH 4/4] crypto: algif_skcipher - Fix stream cipher chaining Herbert Xu
2023-12-10 13:53 ` [LTP] " kernel test robot
2023-12-10 13:53 ` kernel test robot
2023-12-05 8:41 ` [PATCH 4/8] crypto: skcipher - Add lskcipher Herbert Xu
2023-12-05 20:17 ` Eric Biggers
2023-12-06 1:44 ` Herbert Xu
2023-09-14 8:28 ` [PATCH 5/8] crypto: lskcipher - Add compatibility wrapper around ECB Herbert Xu
2023-09-14 8:28 ` [PATCH 6/8] crypto: testmgr - Add support for lskcipher algorithms Herbert Xu
2023-09-14 8:28 ` [PATCH 7/8] crypto: ecb - Convert from skcipher to lskcipher Herbert Xu
2023-09-14 8:28 ` [PATCH 8/8] crypto: cbc " Herbert Xu
2023-10-02 20:25 ` Nathan Chancellor
2023-10-03 3:31 ` [PATCH] crypto: skcipher - Add dependency on ecb Herbert Xu
2023-10-03 15:25 ` Nathan Chancellor
2023-09-14 8:51 ` [PATCH 0/8] crypto: Add lskcipher API type Ard Biesheuvel
2023-09-14 8:56 ` Herbert Xu
2023-09-14 9:18 ` Ard Biesheuvel
2023-09-14 9:29 ` Herbert Xu
2023-09-14 9:31 ` Ard Biesheuvel
2023-09-14 9:34 ` Herbert Xu
2023-09-17 16:24 ` Ard Biesheuvel
2023-09-19 4:03 ` Herbert Xu
2023-09-14 9:32 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129210421.GD1174@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=ardb@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.