All of lore.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Karel Balej <karelb@gimli.ms.mff.cuni.cz>
Cc: "Markuss Broks" <markuss.broks@gmail.com>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Henrik Rydberg" <rydberg@bitmath.org>,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Duje Mihanović" <duje.mihanovic@skole.hr>,
	~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org, "Karel Balej" <balejk@matfyz.cz>
Subject: Re: [PATCH v3 2/5] dt-bindings: input/touchscreen: Add compatible for IST3038B
Date: Sun, 3 Dec 2023 11:20:37 +0000	[thread overview]
Message-ID: <20231203-outskirts-reformat-e0a833903841@spud> (raw)
In-Reply-To: <20231202125948.10345-3-karelb@gimli.ms.mff.cuni.cz>

[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]

On Sat, Dec 02, 2023 at 01:48:33PM +0100, Karel Balej wrote:
> From: Markuss Broks <markuss.broks@gmail.com>
> 
> Imagis IST3038B is a variant (firmware?) of Imagis IST3038 IC,
> add the compatible for it to the IST3038C bindings.

This one is better, but would be well served by mentioning what
specifically is different (register addresses or firmware commands?)

Cheers,
Conor.

> 
> Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
> Signed-off-by: Karel Balej <balejk@matfyz.cz>
> ---
>  .../devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml   | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> index 0d6b033fd5fb..b5372c4eae56 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> @@ -18,6 +18,7 @@ properties:
>  
>    compatible:
>      enum:
> +      - imagis,ist3038b
>        - imagis,ist3038c
>  
>    reg:
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-12-03 11:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-02 12:48 [PATCH v3 0/5] input/touchscreen: imagis: add support for IST3032C Karel Balej
2023-12-02 12:48 ` [PATCH v3 1/5] input/touchscreen: imagis: Correct the maximum touch area value Karel Balej
2023-12-02 12:48 ` [PATCH v3 2/5] dt-bindings: input/touchscreen: Add compatible for IST3038B Karel Balej
2023-12-03 11:20   ` Conor Dooley [this message]
2023-12-04 12:40     ` Markuss Broks
2023-12-04 12:52       ` Conor Dooley
2023-12-09  9:05         ` Karel Balej
2023-12-09 10:58           ` Conor Dooley
2023-12-27 11:55             ` Karel Balej
2023-12-02 12:48 ` [PATCH v3 3/5] input/touchscreen: imagis: Add support for Imagis IST3038B Karel Balej
2023-12-05 10:21   ` kernel test robot
2023-12-02 12:48 ` [PATCH v3 4/5] dt-bindings: input/touchscreen: imagis: add compatible for IST3032C Karel Balej
2023-12-03 11:19   ` Conor Dooley
2023-12-02 12:48 ` [PATCH v3 5/5] input/touchscreen: imagis: add support " Karel Balej
2023-12-04 12:45   ` Markuss Broks
2023-12-08 21:59     ` Karel Balej
2023-12-09 20:50       ` Markuss Broks
2023-12-05 14:49   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231203-outskirts-reformat-e0a833903841@spud \
    --to=conor@kernel.org \
    --cc=balejk@matfyz.cz \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=duje.mihanovic@skole.hr \
    --cc=karelb@gimli.ms.mff.cuni.cz \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markuss.broks@gmail.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rydberg@bitmath.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.