From: Jakub Kicinski <kuba@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH wireless-next 0/3] netlink carrier race workaround
Date: Mon, 4 Dec 2023 08:23:54 -0800 [thread overview]
Message-ID: <20231204082354.78122161@kernel.org> (raw)
In-Reply-To: <efd89dee78a4c42b7825fa55bbceafad9bb9df36.camel@sipsolutions.net>
On Sun, 03 Dec 2023 19:51:28 +0100 Johannes Berg wrote:
> I think I wouldn't mind now, and perhaps if we want to sync in netlink
> we should also do this here so that it's consistent, but I'm not sure
> I'd want this to be the only way to do it, I might imagine that someone
> might want this in some kind of container that doesn't necessarily have
> (full) access there? Dunno.
Also dunno :) We can add a "sync" version of netif_carrier_ok()
and then call if from whatever places we need.
> We _could_ also use an input attribute on the rtnl_getlink() call to
> have userspace explicitly opt in to doing the sync before returning
> information?
Yeah, maybe.. IMHO a more "Rusty Russell API levels" thing to do would
be to allow opting out, as those who set the magic flag "know what they
are doing" and returning unsync'ed carrier may be surprising.
Also a "don't sync flag" we can add later, once someone who actually
cares appears, avoiding uAPI growth 😁️
Anyway, up to you :)
next prev parent reply other threads:[~2023-12-04 16:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 7:52 netif_carrier_on() race Johannes Berg
2023-09-19 12:36 ` Andrew Lunn
2023-09-19 12:40 ` Johannes Berg
2023-09-26 8:07 ` Johannes Berg
2023-12-01 10:41 ` [PATCH wireless-next 0/3] netlink carrier race workaround Johannes Berg
2023-12-01 10:41 ` [PATCH wireless-next 1/3] wifi: nl80211: refactor nl80211_send_mlme_event() arguments Johannes Berg
2023-12-01 10:41 ` [PATCH wireless-next 2/3] wifi: cfg80211: make RX assoc data const Johannes Berg
2023-12-01 10:41 ` [PATCH wireless-next 3/3] wifi: nl80211: report carrier up count to userspace Johannes Berg
2023-12-02 0:28 ` [PATCH wireless-next 0/3] netlink carrier race workaround Jakub Kicinski
2023-12-02 10:06 ` Johannes Berg
2023-12-02 18:46 ` Jakub Kicinski
2023-12-03 18:51 ` Johannes Berg
2023-12-04 16:23 ` Jakub Kicinski [this message]
2023-12-04 19:14 ` Johannes Berg
2023-12-04 19:47 ` Jakub Kicinski
2023-12-01 10:49 ` [PATCH wpa_supplicant 0/2] wpa_supplicant: wait for carrier race Johannes Berg
2023-12-01 10:49 ` [PATCH wpa_suppplicant 1/2] netlink: add netlink_process_one_event() Johannes Berg
2023-12-01 10:49 ` [PATCH wpa_suppplicant 2/2] driver_nl82011: wait for rtnetlink event with carrier_up_count Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204082354.78122161@kernel.org \
--to=kuba@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.