From: Jan Kara <jack@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Jeff Layton <jlayton@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Josef Bacik <josef@toxicpanda.com>, Jan Kara <jack@suse.cz>,
David Howells <dhowells@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Miklos Szeredi <miklos@szeredi.hu>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] fs: fork splice_file_range() from do_splice_direct()
Date: Mon, 4 Dec 2023 18:16:46 +0100 [thread overview]
Message-ID: <20231204171646.fwfa2chhuj5qsesh@quack3> (raw)
In-Reply-To: <CAOQ4uxg+agJ7ybOHfY5bKk_oi=f11zvPLzgnNF5zqZxnkTsUCA@mail.gmail.com>
On Mon 04-12-23 16:29:02, Amir Goldstein wrote:
> On Mon, Dec 4, 2023 at 4:07 PM Christoph Hellwig <hch@lst.de> wrote:
> > On Mon, Dec 04, 2023 at 03:29:43PM +0200, Amir Goldstein wrote:
> > Well, splice_file_range makes sense if it is a separate helper. But when
> > is the default implementation for ->copy_file_range and matches the
> > signature, naming it that way is not only sensible but required to keep
> > sanity.
> >
>
> It is NOT a default implementation of ->copy_file_range(), but
> a fallback helper.
> Specifically, it is never expected to have a filesystem that does
> .copy_file_range = generic_copy_file_range,
> so getting rid of generic_copy_file_range() would be good.
>
> Note also that generic_copy_file_range() gets a flags argument
> that is COPY_FILE_* flags (currently only for the vfs level)
> and this flags argument is NOT the splice flags argument, so
> I intentionally removed the flags argument from splice_file_range()
> to reduce confusion.
>
> I like the idea of moving MAX_RW_COUNT into splice_file_range()
> and replacing generic_copy_file_range() calls with splice_file_range().
>
> I do not feel strongly against splice_copy_file_range() name, but
> I would like to get feedback from other reviewers that approved the
> name splice_file_range() before changing it.
For me the name is not a big deal either way.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2023-12-04 17:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 14:16 [PATCH v2 0/3] Avert possible deadlock with splice() and fanotify Amir Goldstein
2023-11-30 14:16 ` [PATCH v2 1/3] fs: fork splice_file_range() from do_splice_direct() Amir Goldstein
2023-11-30 16:27 ` Jeff Layton
2023-12-04 8:37 ` Christoph Hellwig
2023-12-04 8:38 ` Christoph Hellwig
2023-12-04 13:29 ` Amir Goldstein
2023-12-04 14:07 ` Christoph Hellwig
2023-12-04 14:29 ` Amir Goldstein
2023-12-04 17:16 ` Jan Kara [this message]
2023-12-04 18:53 ` Amir Goldstein
2023-11-30 14:16 ` [PATCH v2 2/3] fs: move file_start_write() into direct_splice_actor() Amir Goldstein
2023-12-04 8:38 ` Christoph Hellwig
2023-11-30 14:16 ` [PATCH v2 3/3] fs: use do_splice_direct() for nfsd/ksmbd server-side-copy Amir Goldstein
2023-11-30 16:49 ` Jan Kara
2023-12-04 8:39 ` Christoph Hellwig
2023-12-04 13:19 ` Amir Goldstein
2023-12-04 14:02 ` Christoph Hellwig
2023-12-05 0:16 ` [PATCH] fs: read_write: make default in vfs_copy_file_range() reachable Bert Karwatzki
2023-12-05 3:45 ` Amir Goldstein
2023-12-05 5:01 ` Amir Goldstein
2023-12-05 9:50 ` Bert Karwatzki
2023-11-30 16:32 ` [PATCH v2 0/3] Avert possible deadlock with splice() and fanotify Jeff Layton
2023-12-01 10:40 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204171646.fwfa2chhuj5qsesh@quack3 \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.