From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>,
linux-mm@kvack.org,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Jan Kara <jack@suse.com>, David Howells <dhowells@redhat.com>,
Brian Foster <bfoster@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/17] writeback: Factor should_writeback_folio() out of write_cache_pages()
Date: Thu, 21 Dec 2023 13:23:14 +0100 [thread overview]
Message-ID: <20231221122314.GD17956@lst.de> (raw)
In-Reply-To: <20231221112206.f6biqpkpwl6w64mo@quack3>
On Thu, Dec 21, 2023 at 12:22:06PM +0100, Jan Kara wrote:
> > +static bool should_writeback_folio(struct address_space *mapping,
> > + struct writeback_control *wbc, struct folio *folio)
> > +{
>
> I'd call this function folio_prepare_writeback() or something like that to
> make it clearer that this function is not only about the decision whether
> we want to write folio or not but we also clear the dirty bit &
> writeprotect the folio in page tables.
Fine with me. I'll wait for willy to chime in if he has a strong
preference.
next prev parent reply other threads:[~2023-12-21 12:23 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 15:35 Convert write_cache_pages() to an iterator v3 Christoph Hellwig
2023-12-18 15:35 ` [PATCH 01/17] writeback: fix done_index when hitting the wbc->nr_to_write Christoph Hellwig
2023-12-19 17:33 ` Jan Kara
2023-12-18 15:35 ` [PATCH 02/17] writeback: also update wbc->nr_to_write on writeback failure Christoph Hellwig
2023-12-19 17:36 ` Jan Kara
2023-12-18 15:35 ` [PATCH 03/17] writeback: rework the loop termination condition in write_cache_pages Christoph Hellwig
2023-12-19 18:27 ` Jan Kara
2023-12-18 15:35 ` [PATCH 04/17] writeback: only update ->writeback_index for range_cyclic writeback Christoph Hellwig
2023-12-21 10:59 ` Jan Kara
2023-12-18 15:35 ` [PATCH 05/17] writeback: remove a duplicate prototype for tag_pages_for_writeback Christoph Hellwig
2023-12-21 10:59 ` Jan Kara
2023-12-18 15:35 ` [PATCH 06/17] writeback: Factor out writeback_finish() Christoph Hellwig
2023-12-21 11:09 ` Jan Kara
2023-12-18 15:35 ` [PATCH 07/17] writeback: Factor writeback_get_batch() out of write_cache_pages() Christoph Hellwig
2023-12-21 11:17 ` Jan Kara
2023-12-21 12:22 ` Christoph Hellwig
2023-12-21 12:30 ` Jan Kara
2023-12-18 15:35 ` [PATCH 08/17] writeback: Factor should_writeback_folio() " Christoph Hellwig
2023-12-21 11:22 ` Jan Kara
2023-12-21 12:23 ` Christoph Hellwig [this message]
2023-12-18 15:35 ` [PATCH 09/17] writeback: Simplify the loops in write_cache_pages() Christoph Hellwig
2023-12-21 11:24 ` Jan Kara
2023-12-18 15:35 ` [PATCH 10/17] pagevec: Add ability to iterate a queue Christoph Hellwig
2023-12-21 11:26 ` Jan Kara
2023-12-18 15:35 ` [PATCH 11/17] writeback: Use the folio_batch queue iterator Christoph Hellwig
2023-12-21 11:28 ` Jan Kara
2023-12-18 15:35 ` [PATCH 12/17] writeback: Factor writeback_iter_init() out of write_cache_pages() Christoph Hellwig
2023-12-21 11:29 ` Jan Kara
2023-12-18 15:35 ` [PATCH 13/17] writeback: Factor writeback_get_folio() " Christoph Hellwig
2023-12-21 11:41 ` Jan Kara
2023-12-21 12:25 ` Christoph Hellwig
2023-12-21 12:31 ` Jan Kara
2023-12-18 15:35 ` [PATCH 14/17] writeback: Factor writeback_iter_next() " Christoph Hellwig
2023-12-21 11:46 ` Jan Kara
2023-12-18 15:35 ` [PATCH 15/17] writeback: Add for_each_writeback_folio() Christoph Hellwig
2023-12-21 11:51 ` Jan Kara
2023-12-21 12:29 ` Christoph Hellwig
2023-12-21 12:49 ` Jan Kara
2023-12-18 15:35 ` [PATCH 16/17] writeback: Remove a use of write_cache_pages() from do_writepages() Christoph Hellwig
2023-12-21 11:53 ` Jan Kara
2023-12-18 15:35 ` [PATCH 17/17] writeback: update the kerneldoc comment for tag_pages_for_writeback Christoph Hellwig
2023-12-21 11:54 ` Jan Kara
2023-12-18 21:00 ` Convert write_cache_pages() to an iterator v3 Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221122314.GD17956@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=dhowells@redhat.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.