Re: [PATCH fstests 1/2] generic/465: don't run it on NFS

From: Zorro Lang <zlang@redhat.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: Anna Schumaker <anna@kernel.org>,
	Trond Myklebust <trondmy@hammerspace.com>,
	Chuck Lever <chuck.lever@oracle.com>,
	Yongcheng Yang <yoyang@redhat.com>,
	linux-nfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH fstests 1/2] generic/465: don't run it on NFS
Date: Fri, 12 Jan 2024 04:47:34 +0800	[thread overview]
Message-ID: <20240111204734.kvsuqvxlzntnyrc4@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com> (raw)
In-Reply-To: <20240110-fixes-v1-1-69f5ddd95656@kernel.org>

On Wed, Jan 10, 2024 at 01:27:27PM -0500, Jeff Layton wrote:
> This test kicks off a thread that issues a read against a file, while
> writing to the file in 1M chunks. It expects that the reader will see
> either the written data or a short read.
> 
> NFS allows DIO reads and writes to run in parallel. That means that it's
> possible for them to race and the reader to see NULLs in the file if
> things get reordered.
> 
> Just skip this test on NFS, since we can't guarantee that it will
> reliably pass.
> 
> Cc: Anna Schumaker <anna@kernel.org>
> Cc: Trond Myklebust <trondmy@hammerspace.com>
> Cc: Chuck Lever <chuck.lever@oracle.com>
> Link: https://lore.kernel.org/linux-nfs/2f7f6d4490ac08013ef78481ff5c7840f41b1bb4.camel@kernel.org/
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---

I've seen several nfs folks agree to skip it on nfs, and no any objection,
so I'll merge this change.

Reviewed-by: Zorro Lang <zlang@redhat.com>

>  tests/generic/465 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/465 b/tests/generic/465
> index 73fdfb5548af..0745d6a1dd3a 100755
> --- a/tests/generic/465
> +++ b/tests/generic/465
> @@ -21,7 +21,7 @@ _cleanup()
>  . ./common/filter
>  
>  # real QA test starts here
> -_supported_fs generic
> +_supported_fs ^nfs
>  
>  _require_aiodio aio-dio-append-write-read-race
>  _require_test_program "feature"
> 
> -- 
> 2.43.0
> 
> 