Re: [PATCH v7 1/9] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill

From: Pekka Paalanen <ppaalanen@gmail.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Jocelyn Falempe <jfalempe@redhat.com>,
	bluescreen_avenger@verizon.net, javierm@redhat.com,
	mripard@kernel.org, gpiccoli@igalia.com, noralf@tronnes.org,
	dri-devel@lists.freedesktop.org, daniel@ffwll.ch,
	airlied@redhat.com
Subject: Re: [PATCH v7 1/9] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill
Date: Fri, 19 Jan 2024 14:25:36 +0200	[thread overview]
Message-ID: <20240119142536.5023860b@eldfell> (raw)
In-Reply-To: <8f8f3cce-3fb3-4f94-a7d5-7c089672a68b@suse.de>

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

On Fri, 19 Jan 2024 11:58:38 +0100
Thomas Zimmermann <tzimmermann@suse.de> wrote:

> Hi
> 
> Am 17.01.24 um 17:40 schrieb Jocelyn Falempe:

...

> > The last thing, is if I plan to add YUV support, with this 
> > implementation, I only need to write one function that convert one 
> > pixel. Otherwise I would need to add the drm_fb_r1_to_yuvxxx_line() and 
> > drm_fb_r1_to_yuvxxxx() boilerplate.  
> 
> 8) YUVs are multi-plane formats IIRC. So it's likely a bit more 
> complicated.And I'm not aware of any current use case for YUV. If the 
> framebuffer console doesn't support it, the panic helper probably won't 
> either.

Kernel panic during a fullscreen video playback, maybe?

That use case is likely to have an YUV FB as the only visible KMS plane
FB, either primary or overlay plane depending on which is capable of
displaying it. Sub-titles might not exist, or might be in a fairly
small RGB overlay.

I don't know if such case is important enough to handle.

Thanks,
pq

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]