All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 4/4] drm/i915/cdclk: Document CDCLK update methods
Date: Wed,  7 Feb 2024 03:33:34 +0200	[thread overview]
Message-ID: <20240207013334.29606-5-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240207013334.29606-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Add a bit of documentation to briefly explain the methods
by which we can change the CDCLK frequency.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_cdclk.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
index ca00586fdbc8..30dae4fef6cb 100644
--- a/drivers/gpu/drm/i915/display/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
@@ -63,6 +63,15 @@
  * DMC will not change the active CDCLK frequency however, so that part
  * will still be performed by the driver directly.
  *
+ * Several methods exist to change the CDCLK frequency, which ones are
+ * supported depends on the platform:
+ * - Full PLL disable + re-enable with new VCO frequency. Pipes must be inactive.
+ * - CD2X divider update. Single pipe can be active as the divider update
+ *   can be synchronized with the pipe's start of vblank.
+ * - Crawl the PLL smoothly to the new VCO frequency. Pipes can be active.
+ * - Squash waveform update. Pipes can be active.
+ * - Crawl and squash can also be done back to back. Pipes can be active.
+ *
  * RAWCLK is a fixed frequency clock, often used by various auxiliary
  * blocks such as AUX CH or backlight PWM. Hence the only thing we
  * really need to know about RAWCLK is its frequency so that various
-- 
2.43.0


  parent reply	other threads:[~2024-02-07  1:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07  1:33 [PATCH 0/4] drm/i915/cdclk: More hardcoded cd2x divider nukage Ville Syrjala
2024-02-07  1:33 ` [PATCH 1/4] drm/i915/cdclk: Extract cdclk_divider() Ville Syrjala
2024-02-16 12:15   ` Gustavo Sousa
2024-02-07  1:33 ` [PATCH 2/4] drm/i915/cdclk: Squash waveform is 16 bits Ville Syrjala
2024-02-16 12:15   ` Gustavo Sousa
2024-02-07  1:33 ` [PATCH 3/4] drm/i915/cdclk: Remove the hardcoded divider from cdclk_compute_crawl_and_squash_midpoint() Ville Syrjala
2024-02-16 12:16   ` Gustavo Sousa
2024-02-07  1:33 ` Ville Syrjala [this message]
2024-02-16 12:51   ` [PATCH 4/4] drm/i915/cdclk: Document CDCLK update methods Gustavo Sousa
2024-02-16 16:00     ` Ville Syrjälä
2024-02-07  2:41 ` ✗ Fi.CI.BAT: failure for drm/i915/cdclk: More hardcoded cd2x divider nukage Patchwork
2024-02-07 16:39 ` ✓ Fi.CI.BAT: success for drm/i915/cdclk: More hardcoded cd2x divider nukage (rev2) Patchwork
2024-02-07 20:08 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-02-10  1:25 ` ✓ Fi.CI.BAT: success for drm/i915/cdclk: More hardcoded cd2x divider nukage (rev3) Patchwork
2024-02-10  7:03 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240207013334.29606-5-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.