All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: compaction: early termination in compact_nodes()
Date: Thu, 8 Feb 2024 13:14:40 -0800	[thread overview]
Message-ID: <20240208131440.e30a650505fac4068ab75ee8@linux-foundation.org> (raw)
In-Reply-To: <20240208022508.1771534-1-wangkefeng.wang@huawei.com>

On Thu, 8 Feb 2024 10:25:08 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:

> No need to continue try compact memory if pending fatal signal,
> allow loop termination earlier in compact_nodes().

Seems sensible, but...  why?  Is there some problem which we can
demonstrate with the existing code?  In other words, does this change
provide any observable benefit under any circumstances?



  reply	other threads:[~2024-02-08 21:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07  9:58 [PATCH] mm: compaction: refactor compact_node() Kefeng Wang
2024-02-07 23:48 ` Andrew Morton
2024-02-08  2:25 ` [PATCH] mm: compaction: early termination in compact_nodes() Kefeng Wang
2024-02-08 21:14   ` Andrew Morton [this message]
2024-02-12 14:22     ` David Hildenbrand
2024-02-17  2:55       ` Kefeng Wang
2024-02-21 22:34         ` Andrew Morton
2024-02-22 14:36           ` Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240208131440.e30a650505fac4068ab75ee8@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.