Re: [PATCH] iproute2: fix build failure on ppc64le

From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrea Claudi <aclaudi@redhat.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com, sgallagh@redhat.com
Subject: Re: [PATCH] iproute2: fix build failure on ppc64le
Date: Fri, 9 Feb 2024 08:35:33 -0800	[thread overview]
Message-ID: <20240209083533.1246ddcc@hermes.local> (raw)
In-Reply-To: <d13ef7c00b60a50a5e8ddbb7ff138399689d3483.1707474099.git.aclaudi@redhat.com>

On Fri,  9 Feb 2024 11:24:47 +0100
Andrea Claudi <aclaudi@redhat.com> wrote:

> ss.c:3244:34: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 2 has type ‘__u64’ {aka ‘long unsigned int’} [-Wformat=]
>  3244 |                 out(" rcv_nxt:%llu", s->mptcpi_rcv_nxt);
>       |                               ~~~^   ~~~~~~~~~~~~~~~~~
>       |                                  |    |
>       |                                  |    __u64 {aka long unsigned int}
>       |                                  long long unsigned int
>       |                               %lu
> 
> This happens because __u64 is defined as long unsigned on ppc64le.  As
> pointed out by Florian Weimar, we should use -D__SANE_USERSPACE_TYPES__
> if we really want to use long long unsigned in iproute2.

Ok, this looks good.
Another way to fix would be to use the macros defined in inttypes.h

		out(" rcv_nxt:"PRIu64, s->mptcpi_rcv_nxt);