Re: [PATCH v3 1/2] usb: core: Amend initial authorized_default value

From: Greg KH <gregkh@linuxfoundation.org>
To: Niko Mauno <niko.mauno@vaisala.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	vesa.jaaskelainen@vaisala.com, geert@linux-m68k.org
Subject: Re: [PATCH v3 1/2] usb: core: Amend initial authorized_default value
Date: Fri, 9 Feb 2024 13:34:17 +0000	[thread overview]
Message-ID: <2024020911-utilize-etching-595a@gregkh> (raw)
In-Reply-To: <65582610-72ba-4644-9032-91c09f50a6bf@vaisala.com>

On Fri, Feb 09, 2024 at 02:39:01PM +0200, Niko Mauno wrote:
> On 9.2.2024 12.47, Greg KH wrote:
> > On Fri, Feb 09, 2024 at 11:46:50AM +0200, niko.mauno@vaisala.com wrote:
> > > From: Niko Mauno <niko.mauno@vaisala.com>
> > > 
> > > Since the wireless USB implementation has been removed and since the
> > > behavior with authorized_default values -1 and 1 is now effectively
> > > same, change the initial value to latter in order to stop using the
> > > leftover value. The former value can still be passed as a module
> > > parameter to retain backwards compatibility.
> > > 
> > > Signed-off-by: Niko Mauno <niko.mauno@vaisala.com>
> > > ---
> > >   drivers/usb/core/hcd.c | 6 ++----
> > >   1 file changed, 2 insertions(+), 4 deletions(-)
> > 
> > Isn't this series already in my tree?
> > 
> > confused,
> > 
> > greg k-h
> 
> Hi Greg, apologies for any confusion I may have caused,
> 
> Geert requested some further clarification in the new Kconfig help section,
> please see:
> https://marc.info/?l=linux-usb&m=170747246528305&w=2

Great, but I can't take patches that are already in my tree, right?

Please submit a new one on top of what I currently have.

> (There shouldn't be any functional change introduced between v2 and v3)

That always needs to be listed, as my bot says, otherwise we have no
idea what is going on here.  Remember, some of us get 1000+ emails a day
to do something with (review, apply, delete, ignore...)

thanks,

greg k-h