From: Lucas Lee Jing Yi <lucasleeeeeeeee@gmail.com>
To: rafael@kernel.org
Cc: Perry.Yuan@amd.com, Xiaojian.Du@amd.com,
alexander.deucher@amd.com, bp@alien8.de, deepak.sharma@amd.com,
li.meng@amd.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-pm@vger.kernel.org, mario.limonciello@amd.com,
nathan.fontenot@amd.com, oleksandr@natalenko.name,
rafael.j.wysocki@intel.com, ray.huang@amd.com,
shimmer.huang@amd.com, skhan@linuxfoundation.org,
viresh.kumar@linaro.org, x86@kernel.org
Subject: Re: [PATCH V14 0/7] amd-pstate preferred core
Date: Mon, 19 Feb 2024 00:10:30 +0800 [thread overview]
Message-ID: <20240218161435.38312-1-lucasleeeeeeeee@gmail.com> (raw)
In-Reply-To: <CAJZ5v0hRk3tME7yeC+1r0RM4-oPPrnSu2=JCsOshBbJp_Nq2Hg@mail.gmail.com>
Dear all,
I have found an issue with the patchset when applying on 6.7, leading to a large degradation in performance.
On my 7840HS on *STOCK* 6.7 highest_perf is reported as 196, not 166 as assumed in the patchset. Applying the patchset causes highest_perf to be misreported and hence a misreported maximum frequency as well, at 4.35GHz instead of 5.14GHz, leading to the degradation in performance.
However, On my 5950X, highest_perf is indeed reported as 166 before and after applying the patchset.
Hence, I propose the following patch (should be attached).
I do apologize for any mistakes as I am new to this and this is my first email on the mailing list.
Cheers!
Lucas
next prev parent reply other threads:[~2024-02-18 16:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 9:04 [PATCH V14 0/7] amd-pstate preferred core Meng Li
2024-01-19 9:04 ` [PATCH V14 1/7] x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for the expansion Meng Li
2024-01-19 9:04 ` [PATCH V14 2/7] ACPI: CPPC: Add get the highest performance cppc control Meng Li
2024-01-19 9:04 ` [PATCH V14 3/7] cpufreq: amd-pstate: Enable amd-pstate preferred core supporting Meng Li
2024-01-19 9:04 ` [PATCH V14 4/7] cpufreq: Add a notification message that the highest perf has changed Meng Li
2024-01-19 9:05 ` [PATCH V14 5/7] cpufreq: amd-pstate: Update amd-pstate preferred core ranking dynamically Meng Li
2024-01-19 9:05 ` [PATCH V14 6/7] Documentation: amd-pstate: introduce amd-pstate preferred core Meng Li
2024-01-19 9:05 ` [PATCH V14 7/7] Documentation: introduce amd-pstate preferrd core mode kernel command line options Meng Li
2024-01-29 15:18 ` [PATCH V14 0/7] amd-pstate preferred core Rafael J. Wysocki
2024-01-29 15:33 ` Borislav Petkov
2024-01-31 13:58 ` Rafael J. Wysocki
2024-02-18 16:10 ` Lucas Lee Jing Yi [this message]
2024-02-18 16:10 ` [PATCH] [PATCH] amd_pstate: fix erroneous highest_perf value on some CPUs Lucas Lee Jing Yi
2024-02-20 7:23 ` Meng, Li (Jassmine)
2024-02-20 9:02 ` Oleksandr Natalenko
2024-02-21 17:19 ` Lucas Lee Jing Yi
2024-02-21 17:19 ` Lucas Lee Jing Yi
2024-02-21 18:47 ` Mario Limonciello
2024-02-19 1:02 ` [PATCH V14 0/7] amd-pstate preferred core Meng, Li (Jassmine)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240218161435.38312-1-lucasleeeeeeeee@gmail.com \
--to=lucasleeeeeeeee@gmail.com \
--cc=Perry.Yuan@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=alexander.deucher@amd.com \
--cc=bp@alien8.de \
--cc=deepak.sharma@amd.com \
--cc=li.meng@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=nathan.fontenot@amd.com \
--cc=oleksandr@natalenko.name \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=shimmer.huang@amd.com \
--cc=skhan@linuxfoundation.org \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.