From: Christoph Hellwig <hch@lst.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Snitzer <snitzer@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Ming Lei <ming.lei@redhat.com>,
dm-devel@lists.linux.dev, linux-block@vger.kernel.org,
Alasdair G Kergon <agk@redhat.com>,
Benjamin Marzinski <bmarzins@redhat.com>,
Mikulas Patocka <mpatocka@redhat.com>
Subject: Re: [git pull] device mapper fixes for 6.8-rc6
Date: Fri, 23 Feb 2024 18:46:29 +0100 [thread overview]
Message-ID: <20240223174629.GB5743@lst.de> (raw)
In-Reply-To: <CAHk-=whmiQC_F1s1bWmOhM8csz_zxL32B=sPGgaz1kiTK_T2iA@mail.gmail.com>
On Fri, Feb 23, 2024 at 09:42:21AM -0800, Linus Torvalds wrote:
> And honestly, "__packed" really is wrong here. Nobody ever wanted it
> to be completely unaligned.
I'll let Ming speak, but I think the idea was to remove the padding
at the end of the structure when embedded into the bio.
>
> I think we might be better off marking it as being 4-byte aligned.
> That would mean that instead of __packed, it is done as
>
> __packed __aligned(4)
>
>
> because "__aligned" on its own only increases alignment (so without
> the __packed it would stay 8-byte aligned).
>
> Then the only part of that structure that might be unaligned is
> "sector_t", and that would only matter on 64-bit architectures.
Does __aligned also work on struct members? If so we could add a
__aligned(8) to bi_sector an get exactly what we want..
next prev parent reply other threads:[~2024-02-23 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 17:17 [git pull] device mapper fixes for 6.8-rc6 Mike Snitzer
2024-02-23 17:42 ` Linus Torvalds
2024-02-23 17:46 ` Christoph Hellwig [this message]
2024-02-23 18:17 ` Linus Torvalds
2024-02-23 18:44 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223174629.GB5743@lst.de \
--to=hch@lst.de \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bmarzins@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.