Re: [PATCH v4 0/4] spi: cadence-qspi: Fix runtime PM and system-wide suspend

From: Dhruva Gole <d-gole@ti.com>
To: "Théo Lebrun" <theo.lebrun@bootlin.com>
Cc: Mark Brown <broonie@kernel.org>, Apurva Nandan <a-nandan@ti.com>,
	<linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Gregory CLEMENT <gregory.clement@bootlin.com>,
	Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Tawfik Bayouk <tawfik.bayouk@mobileye.com>, Nishanth <nm@ti.com>,
	Vignesh <vigneshr@ti.com>
Subject: Re: [PATCH v4 0/4] spi: cadence-qspi: Fix runtime PM and system-wide suspend
Date: Tue, 27 Feb 2024 17:30:01 +0530	[thread overview]
Message-ID: <20240227120001.rozlhxfyf6edwvzc@dhruva> (raw)
In-Reply-To: <CZF1U6LPB3XB.1BXJPWRGB4TH@bootlin.com>

Hi,

On Feb 26, 2024 at 14:36:17 +0100, Théo Lebrun wrote:
> Hello Dhruva,
> 
> On Mon Feb 26, 2024 at 1:18 PM CET, Dhruva Gole wrote:
> > Hi Mark, Theo,
> >
> > + Nishanth, Vignesh (maintainers of TI K3)
> >
> > On Feb 22, 2024 at 19:13:29 +0000, Mark Brown wrote:
> > > On Thu, 22 Feb 2024 11:12:28 +0100, Théo Lebrun wrote:
> > > > This fixes runtime PM and system-wide suspend for the cadence-qspi
> > > > driver. Seeing how runtime PM and autosuspend are enabled by default, I
> > > > believe this affects all users of the driver.
> > > > 
> > > > This series has been tested on both Mobileye EyeQ5 hardware and the TI
> > > > J7200 EVM board, under s2idle.
> > > > 
> > > > [...]
> > > 
> > > Applied to
> > > 
> > >    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
> > > 
> > > Thanks!
> > > 
> > > [1/4] spi: cadence-qspi: fix pointer reference in runtime PM hooks
> > >       commit: 32ce3bb57b6b402de2aec1012511e7ac4e7449dc
> > > [2/4] spi: cadence-qspi: remove system-wide suspend helper calls from runtime PM hooks
> > >       commit: 959043afe53ae80633e810416cee6076da6e91c6
> > > [3/4] spi: cadence-qspi: put runtime in runtime PM hooks names
> > >       commit: 4efa1250b59ebf47ce64a7b6b7c3e2e0a2a9d35a
> > > [4/4] spi: cadence-qspi: add system-wide suspend and resume callbacks
> > >       commit: 078d62de433b4f4556bb676e5dd670f0d4103376
> >
> > It seems like between 6.8.0-rc5-next-20240220 and
> > 6.8.0-rc5-next-20240222 some of TI K3 platform boot have been broken.
> >
> > It particularly seemed related to these patches because we can see
> > cqspi_probe in the call trace and also cqspi_suspend toward the top.
> >
> > See logs for kernel crash in [0] and working in [1]
> 
> I'm guessing we are talking about tags next-20240220 and next-20240222
> on: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/
> 
> Neither of those tags include the patches about fixing PM hooks.
> 
>    ⟩ # next-20240220
>    ⟩ git log --oneline --author theo.lebrun 2d5c7b7eb345 \
>       drivers/spi/spi-cadence-quadspi.c
> 
>    ⟩ # next-20240222
>    ⟩ git log --oneline --author theo.lebrun e31185ce00a9 \
>       drivers/spi/spi-cadence-quadspi.c
>    0f3841a5e115 spi: cadence-qspi: report correct number of chip-select
>    7cc3522aedb5 spi: cadence-qspi: set maximum chip-select to 4
>    0d62c64a8e48 spi: cadence-qspi: assert each subnode flash CS is valid
>    ⟩ # Those are unrelated patches.
> 
> Also it shows from the calltrace: this series renames the runtime
> suspend/resume hooks to cqspi_runtime_* while the callstack you gave
> talks about cqspi_suspend. It only gets called at system-wide suspend
> following this series.
> 
> My guess is that this series will rather fix the issue that you are now
> facing. :-) Could you try applying them and checking if that fixes your
> error?

Indeed, it seems like kernelci generated 22Feb and no future builds in
our case hence we were not testing the -next with your patches applied.

Please pardon the confusion.

The boot logs are here with local linux build from 27 Feb -next:

https://gist.github.com/DhruvaG2000/78ef6f2953b0940ef8ea38797f2ec6cb

It does seem like these patches help us fix the previous regressions.
Thanks for the fixes.

-- 
Best regards,
Dhruva Gole <d-gole@ti.com>