From: Conor Dooley <conor@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: antoniu.miclaus@analog.com, alexandre.belloni@bootlin.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, jdelvare@suse.com, linux@roeck-us.net,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
Subject: Re: [PATCH v8 2/2] dt-bindings: rtc: add max313xx RTCs
Date: Wed, 28 Feb 2024 11:58:01 +0000 [thread overview]
Message-ID: <20240228-embark-rimmed-d81bab3d42b8@spud> (raw)
In-Reply-To: <20240227010312.3305966-3-chris.packham@alliedtelesis.co.nz>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On Tue, Feb 27, 2024 at 02:03:10PM +1300, Chris Packham wrote:
> interrupts:
> + description:
> + Alarm1 interrupt line of the RTC. Some of the RTCs have two interrupt
> + lines and alarm1 interrupt muxing depends on the clockin/clockout
> + configuration.
> maxItems: 1
The maxItems: 1 looks odd here when you state "some of the RTCs have two
interrupt lines", which makes it sound as if there are actually two
interrupts that should be exposed here. If those two interrupts get
muxed to the same pin for output I'd suggest that you clarify that here.
Otherwise, this looks good to me - although I do wonder if the
authorship on the commit (attributed to the analog guys) is still
accurate.
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-02-28 11:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 1:03 [PATCH v8 0/2] drivers: rtc: add max313xx series rtc driver Chris Packham
2024-02-27 1:03 ` [PATCH v8 1/2] rtc: max31335: Add support for additional chips Chris Packham
2024-02-27 2:29 ` Alexandre Belloni
2024-02-27 4:22 ` Chris Packham
2024-02-27 1:03 ` [PATCH v8 2/2] dt-bindings: rtc: add max313xx RTCs Chris Packham
2024-02-28 11:58 ` Conor Dooley [this message]
2024-02-28 20:21 ` Chris Packham
2024-02-29 18:07 ` Conor Dooley
2024-02-29 20:11 ` Chris Packham
2024-02-29 20:29 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228-embark-rimmed-d81bab3d42b8@spud \
--to=conor@kernel.org \
--cc=Ibrahim.Tilki@analog.com \
--cc=Zeynep.Arslanbenzer@analog.com \
--cc=alexandre.belloni@bootlin.com \
--cc=antoniu.miclaus@analog.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.