From: "Darrick J. Wong" <djwong@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org, jlayton@kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] xfs: stop advertising SB_I_VERSION
Date: Wed, 28 Feb 2024 16:09:14 -0800 [thread overview]
Message-ID: <20240229000914.GX1927156@frogsfrogsfrogs> (raw)
In-Reply-To: <Zd/H6pf1YM0mTk1r@dread.disaster.area>
On Thu, Feb 29, 2024 at 10:55:22AM +1100, Dave Chinner wrote:
> On Wed, Feb 28, 2024 at 08:08:48AM -0800, Darrick J. Wong wrote:
> > On Wed, Feb 28, 2024 at 03:28:59PM +1100, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@redhat.com>
> > >
> > > The redefinition of how NFS wants inode->i_version to be updated is
> > > incomaptible with the XFS i_version mechanism. The VFS now wants
> > > inode->i_version to only change when ctime changes (i.e. it has
> > > become a ctime change counter, not an inode change counter). XFS has
> > > fine grained timestamps, so it can just use ctime for the NFS change
> > > cookie like it still does for V4 XFS filesystems.
> > >
> > > We still want XFS to update the inode change counter as it currently
> > > does, so convert all the code that checks SB_I_VERSION to check for
> > > v5 format support. Then we can remove the SB_I_VERSION flag from the
> > > VFS superblock to indicate that inode->i_version is not a valid
> > > change counter and should not be used as such.
> > >
> > > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> >
> > Seeing as NFS and XFS' definition of i_version have diverged, I suppose
> > divorce is the only option. But please, let's get rid of all the
> > *iversion() calls in the codebase.
> >
> > With my paranoia hat on: let's add an i_changecounter to xfs_inode and
> > completely stop using the inode.i_version to prevent the vfs from
> > messing with us.
>
> Ok, I'll do that in a new patch rather than try to do everything in
> a single complicated patch.
Sounds good!
--D
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
>
next prev parent reply other threads:[~2024-02-29 0:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 4:28 [PATCH] xfs: stop advertising SB_I_VERSION Dave Chinner
2024-02-28 16:08 ` Darrick J. Wong
2024-02-28 23:55 ` Dave Chinner
2024-02-29 0:09 ` Darrick J. Wong [this message]
2024-03-01 13:42 ` Jeff Layton
2024-03-03 23:35 ` Dave Chinner
2024-03-04 0:45 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240229000914.GX1927156@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.