Re: [PATCH] dt-bindings: altera-fpga2sdram-bridge: Convert to dtschema

From: Rob Herring <robh@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Animesh Agarwal <animeshagarwal28@gmail.com>,
	mdf@kernel.org, Wu Hao <hao.wu@intel.com>,
	Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-fpga@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: altera-fpga2sdram-bridge: Convert to dtschema
Date: Mon, 4 Mar 2024 11:07:59 -0600	[thread overview]
Message-ID: <20240304170759.GA752387-robh@kernel.org> (raw)
In-Reply-To: <20240301-uphold-numerous-305c3702805b@spud>

On Fri, Mar 01, 2024 at 04:23:30PM +0000, Conor Dooley wrote:
> Hey,
> 
> On Fri, Mar 01, 2024 at 09:46:43PM +0530, Animesh Agarwal wrote:
> > Convert the altera-fpga2sdram-bridge bindings to DT schema.
> > 
> > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> > ---
> >  .../fpga/altera-fpga2sdram-bridge.txt         | 13 -----------
> >  .../fpga/altera-fpga2sdram-bridge.yaml        | 23 +++++++++++++++++++
> >  2 files changed, 23 insertions(+), 13 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> >  create mode 100644 Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> > deleted file mode 100644
> > index 5dd0ff0f7b4e..000000000000
> > --- a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> > +++ /dev/null
> > @@ -1,13 +0,0 @@
> > -Altera FPGA To SDRAM Bridge Driver
> > -
> > -Required properties:
> > -- compatible		: Should contain "altr,socfpga-fpga2sdram-bridge"
> > -
> > -See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
> > -
> > -Example:
> > -	fpga_bridge3: fpga-bridge@ffc25080 {
> > -		compatible = "altr,socfpga-fpga2sdram-bridge";
> > -		reg = <0xffc25080 0x4>;
> > -		bridge-enable = <0>;
> > -	};
> > diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
> > new file mode 100644
> > index 000000000000..88bf9e3151b6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
> > @@ -0,0 +1,23 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/fpga/altr-fpga2sdram-bridge.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Altera FPGA To SDRAM Bridge Driver

Bindings are for h/w blocks, not Drivers.

> > +
> 
> You're missing maintainers: (shouldn't dt_binding_check complain?)

Yes. Patchwork says this failed to apply which is odd because it is 
doubtful that altera-fpga2sdram-bridge.txt has been modified.

Rob