All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Akihiko Odaki" <akihiko.odaki@daynix.com>,
	"Rene Engel" <ReneEngel80@emailn.de>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PULL 11/12] ui/cocoa: Call console_select() with the BQL
Date: Tue,  5 Mar 2024 12:06:06 +0100	[thread overview]
Message-ID: <20240305110608.21618-12-philmd@linaro.org> (raw)
In-Reply-To: <20240305110608.21618-1-philmd@linaro.org>

From: Akihiko Odaki <akihiko.odaki@daynix.com>

[-QemuCocoaView displayConsole:] can be called anytime so explicitly
take the BQL before it calls console_select().

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Tested-by: Rene Engel <ReneEngel80@emailn.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-ID: <20240224-cocoa-v12-9-e89f70bdda71@daynix.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 ui/cocoa.m | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ui/cocoa.m b/ui/cocoa.m
index 6c9efa0c20..bc63043158 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -1379,7 +1379,9 @@ - (void)toggleZoomInterpolation:(id) sender
 /* Displays the console on the screen */
 - (void)displayConsole:(id)sender
 {
-    console_select([sender tag]);
+    with_bql(^{
+        console_select([sender tag]);
+    });
 }
 
 /* Pause the guest */
-- 
2.41.0



  parent reply	other threads:[~2024-03-05 11:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 11:05 [PULL 00/12] Cocoa patches for 2024-03-05 Philippe Mathieu-Daudé
2024-03-05 11:05 ` [PULL 01/12] ui/cocoa: add zoom-interpolation display option Philippe Mathieu-Daudé
2024-03-05 11:05 ` [PULL 02/12] ui/cocoa: Fix window clipping on macOS 14 Philippe Mathieu-Daudé
2024-03-05 11:05 ` [PULL 03/12] ui/cocoa: Split [-QemuCocoaView handleEventLocked:] Philippe Mathieu-Daudé
2024-03-05 11:05 ` [PULL 04/12] ui/cocoa: Immediately call [-QemuCocoaView handleMouseEvent:buttons:] Philippe Mathieu-Daudé
2024-03-05 11:06 ` [PULL 05/12] ui/cocoa: Release specific mouse buttons Philippe Mathieu-Daudé
2024-03-05 11:06 ` [PULL 06/12] ui/cocoa: Scale with NSView instead of Core Graphics Philippe Mathieu-Daudé
2024-03-05 11:06 ` [PULL 07/12] ui/cocoa: Fix pause label coordinates Philippe Mathieu-Daudé
2024-03-05 11:06 ` [PULL 08/12] ui/cocoa: Let the platform toggle fullscreen Philippe Mathieu-Daudé
2024-03-05 11:06 ` [PULL 09/12] ui/cocoa: Remove normalWindow Philippe Mathieu-Daudé
2024-03-05 11:06 ` [PULL 10/12] ui/cocoa: Make window resizable Philippe Mathieu-Daudé
2024-03-05 11:06 ` Philippe Mathieu-Daudé [this message]
2024-03-05 11:06 ` [PULL 12/12] ui/cocoa: Remove stretch_video flag Philippe Mathieu-Daudé
2024-03-05 15:27 ` [PULL 00/12] Cocoa patches for 2024-03-05 Peter Maydell
2024-03-09 14:58 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240305110608.21618-12-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=ReneEngel80@emailn.de \
    --cc=akihiko.odaki@daynix.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.