Re: [RFC PATCH 1/2] sched/fair: Introduce per-task io util boost

From: kernel test robot <lkp@intel.com>
To: Christian Loehle <christian.loehle@arm.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC PATCH 1/2] sched/fair: Introduce per-task io util boost
Date: Thu, 7 Mar 2024 14:20:41 +0800	[thread overview]
Message-ID: <202403071415.olRuAaBL-lkp@intel.com> (raw)
In-Reply-To: <20240304201625.100619-2-christian.loehle@arm.com>

Hi Christian,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on rafael-pm/linux-next peterz-queue/sched/core linus/master v6.8-rc7 next-20240306]
[cannot apply to rafael-pm/acpi-bus rafael-pm/devprop]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Loehle/sched-fair-Introduce-per-task-io-util-boost/20240305-042115
base:   tip/sched/core
patch link:    https://lore.kernel.org/r/20240304201625.100619-2-christian.loehle%40arm.com
patch subject: [RFC PATCH 1/2] sched/fair: Introduce per-task io util boost
config: openrisc-allnoconfig (https://download.01.org/0day-ci/archive/20240307/202403071415.olRuAaBL-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240307/202403071415.olRuAaBL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403071415.olRuAaBL-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/sched/fair.c:6703:22: warning: 'io_boost_rq' defined but not used [-Wunused-function]
    6703 | static unsigned long io_boost_rq(struct cfs_rq *cfs_rq)
         |                      ^~~~~~~~~~~

vim +/io_boost_rq +6703 kernel/sched/fair.c

  6702	
> 6703	static unsigned long io_boost_rq(struct cfs_rq *cfs_rq)
  6704	{
  6705		int i;
  6706	
  6707		for (i = IO_BOOST_LEVELS; i > 0; i--)
  6708			if (atomic_read(&cfs_rq->io_boost_tasks[i - 1]))
  6709				return i * IO_BOOST_UTIL_STEP;
  6710		return 0;
  6711	}
  6712	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki