Re: [PATCH v2 7/7] sparc32: Fix section mismatch in leon_pci_grpci

From: Sam Ravnborg <sam@ravnborg.org>
To: Andreas Larsson <andreas@gaisler.com>
Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>,
	sparclinux@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	linux-parport@lists.infradead.org,
	"David S. Miller" <davem@davemloft.net>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org,
	Arvind Yadav <arvind.yadav.cs@gmail.com>
Subject: Re: [PATCH v2 7/7] sparc32: Fix section mismatch in leon_pci_grpci
Date: Fri, 8 Mar 2024 23:08:12 +0100	[thread overview]
Message-ID: <20240308220812.GA4091237@ravnborg.org> (raw)
In-Reply-To: <c5654b69-209e-4406-ac70-9a4547adfc36@gaisler.com>

Hi Andreas,

On Thu, Mar 07, 2024 at 07:20:11PM +0100, Andreas Larsson wrote:
> On 2024-03-05 16:06, Andreas Larsson wrote:
> > On 2024-02-24 18:42, Sam Ravnborg via B4 Relay wrote:
> >> From: Sam Ravnborg <sam@ravnborg.org>
> >>
> >> Passing a datastructre marked _initconst to platform_driver_register()
> >> is wrong. Drop the __initconst notation.
> >>
> >> This fixes the following warnings:
> >>
> >> WARNING: modpost: vmlinux: section mismatch in reference: grpci1_of_driver+0x30 (section: .data) -> grpci1_of_match (section: .init.rodata)
> >> WARNING: modpost: vmlinux: section mismatch in reference: grpci2_of_driver+0x30 (section: .data) -> grpci2_of_match (section: .init.rodata)
> >>
> >> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> >> Cc: "David S. Miller" <davem@davemloft.net>
> >> Cc: Andreas Larsson <andreas@gaisler.com>
> > 
> > Could you also add
> > 
> > Fixes: 4154bb821f0b ("sparc: leon: grpci1: constify of_device_id")
> > Fixes: 03949b1cb9f1 ("sparc: leon: grpci2: constify of_device_id")
> > 
> > for these fixes in your v3 of the series as well as CCing stable?
> 
> I'll pick up the whole series apart for the ZONE_DMA removal, so there
> is no other need for a v3. I can add the Fixes lines to this one, if it
> is ok with you Sam, or take it as is.

I did not verify the two fixes lines - but seems legit.
So would be super if you add them before applying.

Thanks for picking up the other patches, we are now much closer to
an all{yes,mod}config that can build (but not link).

	Sam