From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: renesas: white-hawk: ethernet: Describe adv1 and avb2
Date: Sat, 9 Mar 2024 15:43:32 +0100 [thread overview]
Message-ID: <20240309144332.GG3735877@ragnatech.se> (raw)
In-Reply-To: <cde6ee0f-31ff-415b-8b77-47936f2a7158@linaro.org>
Hi Krzysztof,
Thanks for your feedback.
On 2024-03-09 12:41:11 +0100, Krzysztof Kozlowski wrote:
> On 09/03/2024 02:30, Niklas Söderlund wrote:
> > +
> > +&pfc {
> > + avb1_pins: avb1 {
> > + mux {
> > + groups = "avb1_link", "avb1_mdio", "avb1_rgmii",
> > + "avb1_txcrefclk";
> > + function = "avb1";
> > + };
> > +
> > + pins_mdio {
>
> You should not use underscores in node names.
My bad will fix in v2. Where I also as you suggest in the binding patch
will use a separate mdio node to describe the bus.
--
Kind Regards,
Niklas Söderlund
prev parent reply other threads:[~2024-03-09 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-09 1:30 [PATCH] arm64: dts: renesas: white-hawk: ethernet: Describe adv1 and avb2 Niklas Söderlund
2024-03-09 11:41 ` Krzysztof Kozlowski
2024-03-09 11:54 ` Biju Das
2024-03-09 14:44 ` Niklas Söderlund
2024-03-09 14:43 ` Niklas Söderlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240309144332.GG3735877@ragnatech.se \
--to=niklas.soderlund+renesas@ragnatech.se \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.