Re: [PATCH vhost v2 1/4] virtio: find_vqs: pass struct instead of multi parameters

From: kernel test robot <lkp@intel.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH vhost v2 1/4] virtio: find_vqs: pass struct instead of multi parameters
Date: Mon, 11 Mar 2024 23:19:33 +0800	[thread overview]
Message-ID: <202403112341.wl8NPpPC-lkp@intel.com> (raw)
In-Reply-To: <20240311072113.67673-2-xuanzhuo@linux.alibaba.com>

Hi Xuan,

kernel test robot noticed the following build errors:

[auto build test ERROR on remoteproc/rproc-next]
[also build test ERROR on s390/features linus/master v6.8 next-20240308]
[cannot apply to uml/next uml/fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Xuan-Zhuo/virtio-find_vqs-pass-struct-instead-of-multi-parameters/20240311-152448
base:   git://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git rproc-next
patch link:    https://lore.kernel.org/r/20240311072113.67673-2-xuanzhuo%40linux.alibaba.com
patch subject: [PATCH vhost v2 1/4] virtio: find_vqs: pass struct instead of multi parameters
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240311/202403112341.wl8NPpPC-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240311/202403112341.wl8NPpPC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403112341.wl8NPpPC-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/virtio/virtio_pci_modern.c: In function 'vp_modern_create_avq':
>> drivers/virtio/virtio_pci_modern.c:761:22: error: assignment of read-only location '*cfg.names'
     761 |         cfg.names[0] = avq->name;
         |                      ^

vim +761 drivers/virtio/virtio_pci_modern.c

   735	
   736	static int vp_modern_create_avq(struct virtio_device *vdev)
   737	{
   738		struct virtio_pci_device *vp_dev = to_vp_device(vdev);
   739		vq_callback_t *callbacks[] = { NULL };
   740		struct virtio_vq_config cfg = {};
   741		struct virtio_pci_admin_vq *avq;
   742		struct virtqueue *vq;
   743		const char *names[1];
   744		u16 admin_q_num;
   745	
   746		cfg.nvqs = 1;
   747		cfg.callbacks = callbacks;
   748		cfg.names = names;
   749	
   750		if (!virtio_has_feature(vdev, VIRTIO_F_ADMIN_VQ))
   751			return 0;
   752	
   753		admin_q_num = vp_modern_avq_num(&vp_dev->mdev);
   754		if (!admin_q_num)
   755			return -EINVAL;
   756	
   757		avq = &vp_dev->admin_vq;
   758		avq->vq_index = vp_modern_avq_index(&vp_dev->mdev);
   759		sprintf(avq->name, "avq.%u", avq->vq_index);
   760	
 > 761		cfg.names[0] = avq->name;
   762		cfg.cfg_idx = 0;
   763		vq = vp_dev->setup_vq(vp_dev, &vp_dev->admin_vq.info, avq->vq_index,
   764				      &cfg, VIRTIO_MSI_NO_VECTOR);
   765		if (IS_ERR(vq)) {
   766			dev_err(&vdev->dev, "failed to setup admin virtqueue, err=%ld",
   767				PTR_ERR(vq));
   768			return PTR_ERR(vq);
   769		}
   770	
   771		vp_modern_set_queue_enable(&vp_dev->mdev, avq->info.vq->index, true);
   772		return 0;
   773	}
   774	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki