All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kobayashi,Daisuke" <kobayashi.da-06@fujitsu.com>
To: kobayashi.da-06@jp.fujitsu.com, linux-cxl@vger.kernel.org
Cc: y-goto@fujitsu.com, linux-pci@vger.kernel.org, mj@ucw.cz,
	dan.j.williams@intel.com,
	"Kobayashi,Daisuke" <kobayashi.da-06@fujitsu.com>
Subject: [PATCH v3 0/3] Display cxl1.1 device link status
Date: Tue, 12 Mar 2024 17:05:56 +0900	[thread overview]
Message-ID: <20240312080559.14904-1-kobayashi.da-06@fujitsu.com> (raw)

Hello.

This patch series adds a feature that displays the link status
of the CXL1.1 device.

CXL devices are extensions of PCIe. Therefore, from CXL2.0 onwards,
the link status can be output in the same way as traditional PCIe.
However, unlike devices from CXL2.0 onwards, CXL1.1 requires a
different method to obtain the link status from traditional PCIe.
This is because the link status of the CXL1.1 device is not mapped
in the configuration space (as per cxl3.0 specification 8.1).
Instead, the configuration space containing the link status is mapped
to the memory mapped register region (as per cxl3.0 specification 8.2,
Table 8-18). Therefore, the current lspci has a problem where it does
not display the link status of the CXL1.1 device. 
This patch solves these issues.

The procedure is as follows:
First, obtain the RCRB address within the cxl driver, then access 
the configuration space. Next, output the link status information from
the configuration space to sysfs. Finally, read sysfs within lspci to 
display the link status information.

Changes
v1[1] -> v2:
The following are the main changes made based on the feedback from Dan Williams.
- Modified to perform rcrb access within the CXL driver.
- Added new attributes to the sysfs of the PCI device.
- Output the link status information to the sysfs of the PCI device.
- Retrieve information from sysfs as the source when displaying information in lspci.

v2[2] -> v3:
- Fix unnecessary initialization and wrong types (Bjohn).
- Create a helper function for getting a PCIe capability offset (Bjohn).
- Move platform-specific implementation to the lib directory in pciutils (Martin).

[1]
https://lore.kernel.org/linux-cxl/20231220050738.178481-1-kobayashi.da-06@fujitsu.com/
[2]
https://lore.kernel.org/linux-cxl/20240227083313.87699-1-kobayashi.da-06@fujitsu.com/

Kobayashi,Daisuke (3):
  Add sysfs attribute for CXL 1.1 device link status
  Remove conditional branch that is not suitable for cxl1.1 devices

 drivers/cxl/acpi.c |   4 -
 drivers/cxl/pci.c  | 193 +++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 193 insertions(+), 4 deletions(-)

  Add function to display cxl1.1 device link status

 lib/access.c | 29 +++++++++++++++++++++
 lib/pci.h    |  2 ++
 ls-caps.c    | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 104 insertions(+)
-- 
2.43.0


             reply	other threads:[~2024-03-12  8:03 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12  8:05 Kobayashi,Daisuke [this message]
2024-03-12  8:05 ` [PATCH v3 1/3] Add sysfs attribute for CXL 1.1 device link status Kobayashi,Daisuke
2024-03-26 19:51   ` Dan Williams
2024-03-28  1:47     ` Daisuke Kobayashi (Fujitsu)
2024-04-03  9:40       ` Daisuke Kobayashi (Fujitsu)
2024-04-05  8:31         ` Daisuke Kobayashi (Fujitsu)
2024-04-08 21:43           ` Dan Williams
2024-04-09  4:55             ` Daisuke Kobayashi (Fujitsu)
2024-04-05 17:25         ` Jonathan Cameron
2024-04-08 21:32         ` Dan Williams
2024-04-09 14:59   ` Bjorn Helgaas
2024-04-09 15:00     ` Bjorn Helgaas
2024-03-12  8:05 ` [PATCH v3 2/3] Remove conditional branch that is not suitable for cxl1.1 devices Kobayashi,Daisuke
2024-03-26 20:00   ` Dan Williams
2024-03-27  8:26     ` Daisuke Kobayashi (Fujitsu)
2024-03-12  8:05 ` [PATCH v3 3/3] Add function to display cxl1.1 device link status Kobayashi,Daisuke
2024-03-26 20:05   ` Dan Williams
2024-03-27  8:27     ` Daisuke Kobayashi (Fujitsu)
2024-03-29 22:23   ` Martin Mareš
2024-03-30  1:15     ` Dan Williams
2024-03-31  1:03       ` Martin Mareš
2024-04-01 17:47         ` Dan Williams
2024-04-02  7:09           ` Daisuke Kobayashi (Fujitsu)
2024-03-25  4:49 ` [PATCH v3 0/3] Display " Daisuke Kobayashi (Fujitsu)
2024-03-26 19:15 ` Dan Williams
2024-03-27  8:24   ` Daisuke Kobayashi (Fujitsu)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240312080559.14904-1-kobayashi.da-06@fujitsu.com \
    --to=kobayashi.da-06@fujitsu.com \
    --cc=dan.j.williams@intel.com \
    --cc=kobayashi.da-06@jp.fujitsu.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mj@ucw.cz \
    --cc=y-goto@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.