Re: [PATCH v6 0/2] Add support for Loongson1 DMA

From: Conor Dooley <conor@kernel.org>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: Keguang Zhang <keguang.zhang@gmail.com>,
	Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-mips@vger.kernel.org, dmaengine@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/2] Add support for Loongson1 DMA
Date: Mon, 18 Mar 2024 11:28:16 +0000	[thread overview]
Message-ID: <20240318-average-likely-6a55c18db7bb@spud> (raw)
In-Reply-To: <CAAhV-H5TR=y_AmbF6QMJmoS0BhfB=K7forMg0-b2YWm7trktjA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 688 bytes --]

On Mon, Mar 18, 2024 at 03:31:59PM +0800, Huacai Chen wrote:
> On Mon, Mar 18, 2024 at 10:08 AM Keguang Zhang <keguang.zhang@gmail.com> wrote:
> >
> > Hi Huacai,
> >
> > > Hi, Keguang,
> > >
> > > Sorry for the late reply, there is already a ls2x-apb-dma driver, I'm
> > > not sure but can they share the same code base? If not, can rename
> > > this driver to ls1x-apb-dma for consistency?
> >
> > There are some differences between ls1x DMA and ls2x DMA, such as
> > registers and DMA descriptors.
> > I will rename it to ls1x-apb-dma.
> OK, please also rename the yaml file to keep consistency.

No, the yaml file needs to match the (one of the) compatible strings.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]