Re: [PATCH] fs: Remove NTFS classic

From: Christian Brauner <brauner@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	 linux-fsdevel@vger.kernel.org,
	linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev,
	 Anton Altaparmakov <anton@tuxera.com>,
	Namjae Jeon <linkinjeon@kernel.org>,
	regressions@lists.linux.dev
Subject: Re: [PATCH] fs: Remove NTFS classic
Date: Mon, 25 Mar 2024 09:28:25 +0100	[thread overview]
Message-ID: <20240325-halbnackt-flutlicht-688f1de80b35@brauner> (raw)
In-Reply-To: <Zf2zPf5TO5oYt3I3@hovoldconsulting.com>

On Fri, Mar 22, 2024 at 05:35:09PM +0100, Johan Hovold wrote:
> On Tue, Jan 16, 2024 at 10:33:49AM +0100, Christian Brauner wrote:
> > On Mon, 15 Jan 2024 07:20:25 +0000, Matthew Wilcox (Oracle) wrote:
> > > The replacement, NTFS3, was merged over two years ago.  It is now time to
> > > remove the original from the tree as it is the last user of several APIs,
> > > and it is not worth changing.
> 
> > I see no reason to not at least try and remove it given that we have
> > ntfs3 as a replacement. Worst case is we have to put it back in. Let's
> > try it.
> 
> This patch breaks boot of my Lenovo ThinkPad X13s where I have an fstab
> entry to access firmware from the original Windows partition; ended up
> in some kind of systemd emergency mode.
> 
> Fix is easy enough once I figured out what broke, but requires changing
> the fs type from 'ntfs' to 'ntfs3' in the fstab (after enabling NTFS3 in
> the kernel config).
> 
> Is it possible to provide an alias or something to avoid breaking
> people's machines like this? Perhaps something is needed for the Kconfig
> too.
> 
> I also now get a bunch of warning when listing the root directory:
> 
> [   68.967970] ntfs3: nvme0n1p3: ino=130d6, Correct links count -> 1.
> [   68.969137] ntfs3: nvme0n1p3: ino=13a, Correct links count -> 1.
> [   68.969798] ntfs3: nvme0n1p3: ino=3ad, Correct links count -> 1.
> [   68.970431] ntfs3: nvme0n1p3: ino=3d9, Correct links count -> 1.
> [   68.971150] ntfs3: nvme0n1p3: ino=26, Correct links count -> 1.
> [   68.971780] ntfs3: nvme0n1p3: ino=eb, Correct links count -> 1.
> [   68.972263] ntfs3: nvme0n1p3: ino=1ce, Correct links count -> 1.
> [   68.973062] ntfs3: nvme0n1p3: ino=a608, Correct links count -> 1.

This shouldn't warn because it's correcting this on the fly.

> 
> Flagging this as a regression so that Thorsten is aware of it:
> 
> #regzbot introduced: 7ffa8f3d3023

Thanks for the report. I'll send a fix.