From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pavan Holla <pholla@chromium.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Subject: Re: [PATCH 1/3] usb: typec: ucsi: Provide interface for UCSI transport
Date: Tue, 26 Mar 2024 10:12:39 +0100 [thread overview]
Message-ID: <2024032603-tactful-exes-f2d0@gregkh> (raw)
In-Reply-To: <20240325-public-ucsi-h-v1-1-7c7e888edc0a@chromium.org>
On Mon, Mar 25, 2024 at 11:37:28PM +0000, Pavan Holla wrote:
> The ucsi.h include can be used by driver implementations that
> provide transport for UCSI commands.
>
> Signed-off-by: Pavan Holla <pholla@chromium.org>
> ---
> MAINTAINERS | 1 +
> include/linux/usb/ucsi.h | 66 ++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 67 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index aa3b947fb080..e799d67a8fa5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -22987,6 +22987,7 @@ F: Documentation/ABI/testing/sysfs-class-typec
> F: Documentation/driver-api/usb/typec.rst
> F: drivers/usb/typec/
> F: include/linux/usb/typec.h
> +F: include/linux/usb/ucsi.h
>
> USB TYPEC INTEL PMC MUX DRIVER
> M: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> diff --git a/include/linux/usb/ucsi.h b/include/linux/usb/ucsi.h
> new file mode 100644
> index 000000000000..3ec1db968070
> --- /dev/null
> +++ b/include/linux/usb/ucsi.h
> @@ -0,0 +1,66 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
No copyright line? I think your employer would not like it if they saw
that :(
Please get review from some internal-to-google developers before
submitting your next version of this series.
thanks,
greg k-h
next prev parent reply other threads:[~2024-03-26 9:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 23:37 [PATCH 0/3] usb: typec: Implement UCSI driver for ChromeOS Pavan Holla
2024-03-25 23:37 ` [PATCH 1/3] usb: typec: ucsi: Provide interface for UCSI transport Pavan Holla
2024-03-26 9:12 ` Greg Kroah-Hartman [this message]
2024-03-26 23:48 ` Pavan Holla
2024-03-25 23:37 ` [PATCH 2/3] usb: typec: ucsi: Import " Pavan Holla
2024-03-26 2:11 ` Prashant Malani
2024-03-27 3:46 ` Pavan Holla
2024-03-25 23:37 ` [PATCH 3/3] platform/chrome: cros_ec_ucsi: Implement UCSI PDC driver Pavan Holla
2024-03-26 8:46 ` Krzysztof Kozlowski
2024-03-26 23:47 ` kernel test robot
2024-03-28 9:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024032603-tactful-exes-f2d0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abhishekpandit@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pholla@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.