From: Simon Horman <horms@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, michal.kubiak@intel.com, rkannoth@marvell.com,
jiri@resnulli.us, shenjian15@huawei.com, wangjie125@huawei.com,
liuyonglong@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 net 2/3] net: hns3: fix kernel crash when devlink reload during pf initialization
Date: Tue, 26 Mar 2024 11:22:38 +0000 [thread overview]
Message-ID: <20240326112238.GM403975@kernel.org> (raw)
In-Reply-To: <20240325124311.1866197-3-shaojijie@huawei.com>
On Mon, Mar 25, 2024 at 08:43:10PM +0800, Jijie Shao wrote:
> From: Yonglong Liu <liuyonglong@huawei.com>
>
> The devlink reload process will access the hardware resources,
> but the register operation is done before the hardware is initialized.
> So, processing the devlink reload during initialization may lead to kernel
> crash. This patch fixes this by taking devl_lock during initialization.
>
> Fixes: b741269b2759 ("net: hns3: add support for registering devlink for PF")
> Signed-off-by: Yonglong Liu <liuyonglong@huawei.com>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-03-26 11:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 12:43 [PATCH V4 net 0/3] There are some bugfix for the HNS3 ethernet driver Jijie Shao
2024-03-25 12:43 ` [PATCH V4 net 1/3] net: hns3: fix index limit to support all queue stats Jijie Shao
2024-03-26 11:22 ` Simon Horman
2024-03-25 12:43 ` [PATCH V4 net 2/3] net: hns3: fix kernel crash when devlink reload during pf initialization Jijie Shao
2024-03-26 11:22 ` Simon Horman [this message]
2024-03-25 12:43 ` [PATCH V4 net 3/3] net: hns3: mark unexcuted loopback test result as UNEXECUTED Jijie Shao
2024-03-26 11:30 ` Simon Horman
2024-03-26 14:40 ` [PATCH V4 net 0/3] There are some bugfix for the HNS3 ethernet driver patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326112238.GM403975@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.