Re: [PATCH net-next] gve: Add counter adminq_get_ptype_map_cnt to stats report

From: Simon Horman <horms@kernel.org>
To: John Fraker <jfraker@google.com>
Cc: netdev@vger.kernel.org, Jeroen de Borst <jeroendb@google.com>,
	Praveen Kaligineedi <pkaligineedi@google.com>,
	Shailend Chand <shailend@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Willem de Bruijn <willemb@google.com>,
	Harshitha Ramamurthy <hramamurthy@google.com>,
	Junfeng Guo <junfeng.guo@intel.com>
Subject: Re: [PATCH net-next] gve: Add counter adminq_get_ptype_map_cnt to stats report
Date: Tue, 26 Mar 2024 14:46:27 +0000	[thread overview]
Message-ID: <20240326144627.GB403975@kernel.org> (raw)
In-Reply-To: <20240325223308.618671-1-jfraker@google.com>

+ Jeroen de Borst, Praveen Kaligineedi, Shailend Chand, David Miller,
  Eric Dumazet, Jakub Kicinski, Paolo Abeni, Willem de Bruijn,
  Harshitha Ramamurthy, Junfeng Guo

On Mon, Mar 25, 2024 at 03:33:08PM -0700, John Fraker wrote:
> This counter counts the number of times get_ptype_map is executed on the
> admin queue, and was previously missing from the stats report.
> 
> Signed-off-by: John Fraker <jfraker@google.com>
> ---
>  drivers/net/ethernet/google/gve/gve_ethtool.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks John,

this looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>

In future, please consider using ./scripts/get_maintainer.pl file.patch
to seed the CC list when posting patches to netdev.

> diff --git a/drivers/net/ethernet/google/gve/gve_ethtool.c b/drivers/net/ethernet/google/gve/gve_ethtool.c
> index 9aebfb843..dbe05402d 100644
> --- a/drivers/net/ethernet/google/gve/gve_ethtool.c
> +++ b/drivers/net/ethernet/google/gve/gve_ethtool.c
> @@ -73,7 +73,7 @@ static const char gve_gstrings_adminq_stats[][ETH_GSTRING_LEN] = {
>  	"adminq_create_tx_queue_cnt", "adminq_create_rx_queue_cnt",
>  	"adminq_destroy_tx_queue_cnt", "adminq_destroy_rx_queue_cnt",
>  	"adminq_dcfg_device_resources_cnt", "adminq_set_driver_parameter_cnt",
> -	"adminq_report_stats_cnt", "adminq_report_link_speed_cnt"
> +	"adminq_report_stats_cnt", "adminq_report_link_speed_cnt", "adminq_get_ptype_map_cnt"
>  };
>  
>  static const char gve_gstrings_priv_flags[][ETH_GSTRING_LEN] = {
> @@ -428,6 +428,7 @@ gve_get_ethtool_stats(struct net_device *netdev,
>  	data[i++] = priv->adminq_set_driver_parameter_cnt;
>  	data[i++] = priv->adminq_report_stats_cnt;
>  	data[i++] = priv->adminq_report_link_speed_cnt;
> +	data[i++] = priv->adminq_get_ptype_map_cnt;
>  }
>  
>  static void gve_get_channels(struct net_device *netdev,
> -- 
> 2.44.0.291.gc1ea87d7ee-goog
> 