From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Jason Xing <kerneljasonxing@gmail.com>,
edumazet@google.com, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, rostedt@goodmis.org,
davem@davemloft.net, netdev@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next v2 3/3] tcp: add location into reset trace process
Date: Thu, 28 Mar 2024 18:15:30 -0700 [thread overview]
Message-ID: <20240328181530.0d9229cb@kernel.org> (raw)
In-Reply-To: <3186e70ecd98893710f829723f866ab92250ea74.camel@redhat.com>
On Tue, 26 Mar 2024 12:08:01 +0100 Paolo Abeni wrote:
> > - TP_PROTO(const struct sock *sk, const struct sk_buff *skb),
> > + TP_PROTO(
> > + const struct sock *sk,
> > + const struct sk_buff *skb,
> > + void *location),
>
> Very minor nit: the above lines should be aligned with the open
> bracket.
Yes, and a very odd way of breaking it up. Empty line after ( but
) not on a separate line.
> No need to repost just for this, but let's wait for Eric's feedback.
Erring on the side of caution I'd read this:
https://lore.kernel.org/all/CANn89iKK-qPhQ91Sq8rR_=KDWajnY2=Et2bUjDsgoQK4wxFOHw@mail.gmail.com/
as lukewarm towards tp changes. Please repost if you think otherwise
(with the formatting fixed)
--
pw-bot: cr
next prev parent reply other threads:[~2024-03-29 1:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 6:28 [PATCH net-next v2 0/3] tcp: make trace of reset logic complete Jason Xing
2024-03-25 6:28 ` [PATCH net-next v2 1/3] trace: adjust TP_STORE_ADDR_PORTS_SKB() parameters Jason Xing
2024-03-25 6:28 ` [PATCH net-next v2 2/3] trace: tcp: fully support trace_tcp_send_reset Jason Xing
2024-03-25 6:28 ` [PATCH net-next v2 3/3] tcp: add location into reset trace process Jason Xing
2024-03-26 11:08 ` Paolo Abeni
2024-03-29 1:15 ` Jakub Kicinski [this message]
2024-03-29 2:53 ` Jason Xing
2024-03-26 1:30 ` [PATCH net-next v2 0/3] tcp: make trace of reset logic complete Jakub Kicinski
2024-03-26 2:13 ` Jason Xing
2024-03-26 2:23 ` Jakub Kicinski
2024-03-26 2:33 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328181530.0d9229cb@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.