From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 05/22] drm/i915: Remove DRM_MODE_FLAG_DBLSCAN checks from .mode_valid() hooks
Date: Fri, 29 Mar 2024 03:12:37 +0200 [thread overview]
Message-ID: <20240329011254.24160-6-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240329011254.24160-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
We never set connector->doublescan_allowed, so the probe helper
already filters out all doublescan modes for us.
Sadly we still need to keep the explicit doublescan checks
in .compute_config as outlined in commit e4dd27aadd20
("drm/i915: Allow DBLSCAN user modes with eDP/LVDS/DSI")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_crt.c | 3 ---
drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 -----
drivers/gpu/drm/i915/display/intel_dsi.c | 3 ---
drivers/gpu/drm/i915/display/intel_dvo.c | 3 ---
drivers/gpu/drm/i915/display/intel_lvds.c | 3 ---
drivers/gpu/drm/i915/display/intel_sdvo.c | 3 ---
drivers/gpu/drm/i915/display/intel_tv.c | 3 ---
7 files changed, 23 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/display/intel_crt.c
index 93479db0f89f..2e95093aa4d4 100644
--- a/drivers/gpu/drm/i915/display/intel_crt.c
+++ b/drivers/gpu/drm/i915/display/intel_crt.c
@@ -356,9 +356,6 @@ intel_crt_mode_valid(struct drm_connector *connector,
if (status != MODE_OK)
return status;
- if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
- return MODE_NO_DBLESCAN;
-
if (mode->clock < 25000)
return MODE_CLOCK_LOW;
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index 53aec023ce92..9a7c75039989 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -1302,11 +1302,6 @@ intel_dp_mst_mode_valid_ctx(struct drm_connector *connector,
if (*status != MODE_OK)
return 0;
- if (mode->flags & DRM_MODE_FLAG_DBLSCAN) {
- *status = MODE_NO_DBLESCAN;
- return 0;
- }
-
max_link_clock = intel_dp_max_link_rate(intel_dp);
max_lanes = intel_dp_max_lane_count(intel_dp);
diff --git a/drivers/gpu/drm/i915/display/intel_dsi.c b/drivers/gpu/drm/i915/display/intel_dsi.c
index d3cf6a652221..2dfc60e4b615 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi.c
@@ -69,9 +69,6 @@ enum drm_mode_status intel_dsi_mode_valid(struct drm_connector *connector,
drm_dbg_kms(&dev_priv->drm, "\n");
- if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
- return MODE_NO_DBLESCAN;
-
status = intel_panel_mode_valid(intel_connector, mode);
if (status != MODE_OK)
return status;
diff --git a/drivers/gpu/drm/i915/display/intel_dvo.c b/drivers/gpu/drm/i915/display/intel_dvo.c
index c076da75b066..060328c0df7e 100644
--- a/drivers/gpu/drm/i915/display/intel_dvo.c
+++ b/drivers/gpu/drm/i915/display/intel_dvo.c
@@ -231,9 +231,6 @@ intel_dvo_mode_valid(struct drm_connector *_connector,
if (status != MODE_OK)
return status;
- if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
- return MODE_NO_DBLESCAN;
-
/* XXX: Validate clock range */
if (fixed_mode) {
diff --git a/drivers/gpu/drm/i915/display/intel_lvds.c b/drivers/gpu/drm/i915/display/intel_lvds.c
index 221f5c6c871b..24860945f2e4 100644
--- a/drivers/gpu/drm/i915/display/intel_lvds.c
+++ b/drivers/gpu/drm/i915/display/intel_lvds.c
@@ -399,9 +399,6 @@ intel_lvds_mode_valid(struct drm_connector *_connector,
if (status != MODE_OK)
return status;
- if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
- return MODE_NO_DBLESCAN;
-
status = intel_panel_mode_valid(connector, mode);
if (status != MODE_OK)
return status;
diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
index 50f0557d9ca2..df76044a739a 100644
--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
@@ -1952,9 +1952,6 @@ intel_sdvo_mode_valid(struct drm_connector *connector,
if (status != MODE_OK)
return status;
- if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
- return MODE_NO_DBLESCAN;
-
if (clock > max_dotclk)
return MODE_CLOCK_HIGH;
diff --git a/drivers/gpu/drm/i915/display/intel_tv.c b/drivers/gpu/drm/i915/display/intel_tv.c
index ba5d2b7174b7..79d35c1b3c81 100644
--- a/drivers/gpu/drm/i915/display/intel_tv.c
+++ b/drivers/gpu/drm/i915/display/intel_tv.c
@@ -969,9 +969,6 @@ intel_tv_mode_valid(struct drm_connector *connector,
if (status != MODE_OK)
return status;
- if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
- return MODE_NO_DBLESCAN;
-
if (mode->clock > max_dotclk)
return MODE_CLOCK_HIGH;
--
2.43.2
next prev parent reply other threads:[~2024-03-29 1:13 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 1:12 [PATCH 00/22] drm/i915: Bigjoiner modeset sequence redesign and MST support Ville Syrjala
2024-03-29 1:12 ` [PATCH 01/22] drm/i915: Disable port sync when bigjoiner is used Ville Syrjala
2024-04-01 5:57 ` Kulkarni, Vandita
2024-03-29 1:12 ` [PATCH 02/22] drm/i915: Fix intel_modeset_pipe_config_late() for bigjoiner Ville Syrjala
2024-04-01 9:23 ` Kulkarni, Vandita
2024-03-29 1:12 ` [PATCH 03/22] drm/i915: Disable live M/N updates when using bigjoiner Ville Syrjala
2024-04-01 10:32 ` Murthy, Arun R
2024-03-29 1:12 ` [PATCH 04/22] drm/i915/vrr: Disable VRR " Ville Syrjala
2024-04-01 10:04 ` Kulkarni, Vandita
2024-03-29 1:12 ` Ville Syrjala [this message]
2024-04-01 11:25 ` [PATCH 05/22] drm/i915: Remove DRM_MODE_FLAG_DBLSCAN checks from .mode_valid() hooks Kulkarni, Vandita
2024-03-29 1:12 ` [PATCH 06/22] drm/i915: Shuffle DP .mode_valid() checks Ville Syrjala
2024-04-01 10:35 ` Kulkarni, Vandita
2024-03-29 1:12 ` [PATCH 07/22] drm/i915: Clean up glk_pipe_scaler_clock_gating_wa() Ville Syrjala
2024-04-01 11:08 ` Kulkarni, Vandita
2024-03-29 1:12 ` [PATCH 08/22] drm/i915: Extract glk_need_scaler_clock_gating_wa() Ville Syrjala
2024-04-01 11:09 ` Kulkarni, Vandita
2024-03-29 1:12 ` [PATCH 09/22] drm/i915: s/intel_dp_can_bigjoiner()/intel_dp_can_bigjoiner()/ Ville Syrjala
2024-04-01 10:01 ` Kulkarni, Vandita
2024-03-29 1:12 ` [PATCH 10/22] drm/i915: Extract intel_dp_joiner_needs_dsc() Ville Syrjala
2024-04-01 9:22 ` Shankar, Uma
2024-03-29 1:12 ` [PATCH 11/22] drm/i915/mst: Check intel_dp_joiner_needs_dsc() Ville Syrjala
2024-04-01 9:28 ` Shankar, Uma
2024-03-29 1:12 ` [PATCH 12/22] drm/i915: Pass connector to intel_dp_need_bigjoiner() Ville Syrjala
2024-04-01 9:39 ` Shankar, Uma
2024-03-29 1:12 ` [PATCH 13/22] drm/i915/mst: Limit MST+DSC to TGL+ Ville Syrjala
2024-04-01 9:44 ` Shankar, Uma
2024-03-29 1:12 ` [PATCH 14/22] drm/i915/mst: Reject FEC+MST on ICL Ville Syrjala
2024-04-01 9:45 ` Shankar, Uma
2024-03-29 1:12 ` [PATCH 15/22] drm/i915: Introduce intel_crtc_joined_pipe_mask() Ville Syrjala
2024-04-01 10:20 ` Murthy, Arun R
2024-03-29 1:12 ` [PATCH 16/22] drm/i915: Extract intel_ddi_post_disable_hdmi_or_sst() Ville Syrjala
2024-04-01 10:17 ` Murthy, Arun R
2024-03-29 1:12 ` [PATCH 17/22] drm/i915: Utilize intel_crtc_joined_pipe_mask() more Ville Syrjala
2024-04-01 6:52 ` Murthy, Arun R
2024-03-29 1:12 ` [PATCH 18/22] drm/i915: Handle joined pipes inside hsw_crtc_disable() Ville Syrjala
2024-04-01 6:46 ` Murthy, Arun R
2024-04-02 19:50 ` Ville Syrjälä
2024-04-03 4:32 ` Murthy, Arun R
2024-03-29 1:12 ` [PATCH 19/22] drm/i915: Handle joined pipes inside hsw_crtc_enable() Ville Syrjala
2024-03-29 1:12 ` [PATCH 20/22] drm/i915/mst: Add bigjoiner handling to MST modeset sequence Ville Syrjala
2024-04-01 6:33 ` Murthy, Arun R
2024-03-29 1:12 ` [PATCH 21/22] drm/i915: Allow bigjoiner for MST Ville Syrjala
2024-04-01 6:26 ` Murthy, Arun R
2024-03-29 1:12 ` [PATCH 22/22] drm/i915: Use debugfs_create_bool() for "i915_bigjoiner_force_enable" Ville Syrjala
2024-04-01 5:08 ` Murthy, Arun R
2024-04-02 7:37 ` Srinivas, Vidya
2024-03-29 6:36 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Bigjoiner modeset sequence redesign and MST support Patchwork
2024-03-29 6:36 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-03-29 6:49 ` ✓ Fi.CI.BAT: success " Patchwork
2024-03-30 6:58 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240329011254.24160-6-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.