All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Nurpmeso <steffen@sdaoden.eu>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: dash@vger.kernel.org,
	Ganael LAPLANCHE <ganael.laplanche@martymac.org>,
	Jilles Tjoelker <jilles@stack.nl>
Subject: Re: [v2 PATCH] jobs: Allow monitor mode without a tty in non-interactive mode
Date: Tue, 09 Apr 2024 00:54:20 +0200	[thread overview]
Message-ID: <20240408225420.hz8nC3ly@steffen%sdaoden.eu> (raw)
In-Reply-To: <ZhJhpbIEe1RyBfk0@gondor.apana.org.au>

Hello.

Sorry for the late response.

Herbert Xu wrote in
 <ZhJhpbIEe1RyBfk0@gondor.apana.org.au>:
 |On Mon, Jan 30, 2023 at 10:15:40PM +0100, Steffen Nurpmeso wrote:
 |> This is a take-over of the FreeBSD bin/sh
 |> 
 |>   commit cd60e2c67d52e1f957841af19128c7227880743a
 |>   Author:     Jilles Tjoelker <jilles@FreeBSD.org>
 |>   AuthorDate: 2014-09-04 21:48:33 +0000
 |>   Commit:     Jilles Tjoelker <jilles@FreeBSD.org>
 |>   CommitDate: 2014-09-04 21:48:33 +0000
 |> 
 |>       sh: Allow enabling job control without a tty in non-interactive \
 |>       mode.
 |> 
 |>       If no tty is available, 'set -m' is still useful to put jobs \
 |>       in their own
 |>       process groups.
 ...
 |Thanks for the patch.  I've rewritten it to minimise the impact.

The patch is much smaller.

 |However, the end result should be fairly similar.
 |
 |Please test this and let me know if there are any issues.

Running the script with it has the desired result.

  ..
 --End of <ZhJhpbIEe1RyBfk0@gondor.apana.org.au>

Ciao, and greetings from Germany,

--steffen
|
|Der Kragenbaer,                The moon bear,
|der holt sich munter           he cheerfully and one by one
|einen nach dem anderen runter  wa.ks himself off
|(By Robert Gernhardt)

  reply	other threads:[~2024-04-08 22:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-30 21:15 [PATCH] Allow enabling job control without a tty in non-interactive mode Steffen Nurpmeso
2024-04-06  7:22 ` Herbert Xu
2024-04-06 23:07   ` Steffen Nurpmeso
2024-04-07  5:21     ` Herbert Xu
2024-04-07  9:04 ` [v2 PATCH] jobs: Allow monitor mode " Herbert Xu
2024-04-08 22:54   ` Steffen Nurpmeso [this message]
2024-04-09 10:11     ` Ganael Laplanche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240408225420.hz8nC3ly@steffen%sdaoden.eu \
    --to=steffen@sdaoden.eu \
    --cc=dash@vger.kernel.org \
    --cc=ganael.laplanche@martymac.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jilles@stack.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.