From: Julien Grall <julien@xen.org>
To: Michal Orzel <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH 1/2] xen/arm32: head: Move earlyprintk 'hex' to .rodata.idmap
Date: Mon, 15 Jan 2024 18:51:25 +0000 [thread overview]
Message-ID: <204abd64-7d16-43f8-acb2-55e84a37a510@xen.org> (raw)
In-Reply-To: <20240115124859.89218-2-michal.orzel@amd.com>
Hi Michal,
On 15/01/2024 12:48, Michal Orzel wrote:
> Thanks to 1ec3fe1f664f ("xen/arm32: head: Improve logging in head.S"),
> we can now use PRINT_ID() macro to print messages when running on
> identity mapping. For that, all the strings need to be part of the first
> page that is mapped. This is not the case for a 'hex' string (used by
> asm_putn when printing register values), which currently resides in
> .rodata.str. Move it to .rodata.idmap to allow making use of print_reg
> macro from anywhere (mostly to aid debugging).
>
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
Acked-by: Julien Grall <jgrall@amazon.com>
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2024-01-15 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 12:48 [PATCH 0/2] xen/arm: head: early printk on 1:1 mapping Michal Orzel
2024-01-15 12:48 ` [PATCH 1/2] xen/arm32: head: Move earlyprintk 'hex' to .rodata.idmap Michal Orzel
2024-01-15 18:51 ` Julien Grall [this message]
2024-01-15 12:48 ` [PATCH 2/2] xen/arm64: head: Allow to use early printk while on 1:1 mapping Michal Orzel
2024-01-15 19:30 ` Julien Grall
2024-01-15 19:31 ` [PATCH 0/2] xen/arm: head: early printk " Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=204abd64-7d16-43f8-acb2-55e84a37a510@xen.org \
--to=julien@xen.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.