From: "Arnd Bergmann" <arnd@arndb.de>
To: "Eric Dumazet" <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Steffen Klassert" <steffen.klassert@secunet.com>
Cc: Netdev <netdev@vger.kernel.org>, eric.dumazet@gmail.com
Subject: Re: [PATCH net 1/2] xfrm: consistently use time64_t in xfrm_timer_handler()
Date: Thu, 26 Jan 2023 13:04:12 +0100 [thread overview]
Message-ID: <20891683-5df9-42f8-b7a8-2b9cff679062@app.fastmail.com> (raw)
In-Reply-To: <20230126112130.2341075-2-edumazet@google.com>
On Thu, Jan 26, 2023, at 12:21, Eric Dumazet wrote:
> For some reason, blamed commit did the right thing in xfrm_policy_timer()
> but did not in xfrm_timer_handler()
>
> Fixes: 386c5680e2e8 ("xfrm: use time64_t for in-kernel timestamps")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Steffen Klassert <steffen.klassert@secunet.com>
I don't remember anything about this one. I thought that perhaps it
was using 'long' for a relative value that is guaranteed to fit
but needs an otherwise expensive 64-bit division. I don't see
any of that though, it looks like an obvious bug.
Thanks for fixing it,
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2023-01-26 12:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 11:21 [PATCH net 0/2] xfrm: two fixes around use_time Eric Dumazet
2023-01-26 11:21 ` [PATCH net 1/2] xfrm: consistently use time64_t in xfrm_timer_handler() Eric Dumazet
2023-01-26 12:04 ` Arnd Bergmann [this message]
2023-01-26 11:21 ` [PATCH net 2/2] xfrm: annotate data-race around use_time Eric Dumazet
2023-01-26 12:05 ` Arnd Bergmann
2023-01-30 10:31 ` [PATCH net 0/2] xfrm: two fixes " Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20891683-5df9-42f8-b7a8-2b9cff679062@app.fastmail.com \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.