From: Jason Wang <jasowang@redhat.com>
To: Yangtao Li <tiny.windzz@gmail.com>, mst@redhat.com
Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource
Date: Mon, 23 Dec 2019 16:43:40 +0800 [thread overview]
Message-ID: <209a1d81-00f7-ab22-ccca-36c1a014b345@redhat.com> (raw)
In-Reply-To: <20191222190839.4863-1-tiny.windzz@gmail.com>
On 2019/12/23 上午3:08, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code, which
> contains platform_get_resource, devm_request_mem_region and
> devm_ioremap.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/virtio/virtio_mmio.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
> index e09edb5c5e06..97d5725fd9a2 100644
> --- a/drivers/virtio/virtio_mmio.c
> +++ b/drivers/virtio/virtio_mmio.c
> @@ -531,18 +531,9 @@ static void virtio_mmio_release_dev(struct device *_d)
> static int virtio_mmio_probe(struct platform_device *pdev)
> {
> struct virtio_mmio_device *vm_dev;
> - struct resource *mem;
> unsigned long magic;
> int rc;
>
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!mem)
> - return -EINVAL;
> -
> - if (!devm_request_mem_region(&pdev->dev, mem->start,
> - resource_size(mem), pdev->name))
> - return -EBUSY;
> -
> vm_dev = devm_kzalloc(&pdev->dev, sizeof(*vm_dev), GFP_KERNEL);
> if (!vm_dev)
> return -ENOMEM;
> @@ -554,9 +545,9 @@ static int virtio_mmio_probe(struct platform_device *pdev)
> INIT_LIST_HEAD(&vm_dev->virtqueues);
> spin_lock_init(&vm_dev->lock);
>
> - vm_dev->base = devm_ioremap(&pdev->dev, mem->start, resource_size(mem));
> - if (vm_dev->base == NULL)
> - return -EFAULT;
> + vm_dev->base = devm_platform_ioremap_resource(pdev, 0);
> + if (IS_ERR(vm_dev->base))
> + return PTR_ERR(vm_dev->base);
>
> /* Check magic value */
> magic = readl(vm_dev->base + VIRTIO_MMIO_MAGIC_VALUE);
Acked-by: Jason Wang <jasowang@redhat.com>
next prev parent reply other threads:[~2019-12-23 8:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-22 19:08 [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-22 19:08 ` Yangtao Li
2019-12-23 8:43 ` Jason Wang
2019-12-23 8:43 ` Jason Wang [this message]
2019-12-23 18:59 [PATCH 1/6] iommu/omap: " Yangtao Li
2019-12-23 18:59 ` [PATCH] virtio-mmio: " Yangtao Li
2019-12-23 18:59 ` Yangtao Li
2019-12-23 18:59 ` Yangtao Li
2019-12-23 18:59 ` Yangtao Li
2019-12-23 18:59 ` Yangtao Li
2019-12-23 19:00 ` Frank Lee
2019-12-23 19:00 ` Frank Lee
2019-12-23 19:00 ` Frank Lee
2019-12-23 19:00 ` Frank Lee
2019-12-23 19:00 ` Frank Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=209a1d81-00f7-ab22-ccca-36c1a014b345@redhat.com \
--to=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=tiny.windzz@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.