Re: [PATCH 1/8] tests/docker: Fix alpine dockerfile

From: Thomas Huth <thuth@redhat.com>
To: "Lucas Mateus Castro(alqotel)" <lucas.araujo@eldorado.org.br>,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Willian Rampazzo" <willianr@redhat.com>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	"Eric Blake" <eblake@redhat.com>
Subject: Re: [PATCH 1/8] tests/docker: Fix alpine dockerfile
Date: Thu, 28 Jul 2022 08:52:24 +0200	[thread overview]
Message-ID: <20d60b18-3ecc-9fbf-f853-1480b2935e05@redhat.com> (raw)
In-Reply-To: <20220727163632.59806-2-lucas.araujo@eldorado.org.br>

On 27/07/2022 18.36, Lucas Mateus Castro(alqotel) wrote:
> Currently the run script uses 'readlink -e' but the image only has the
> busybox readlink, this commit add the coreutils package which
> contains the readlink with the '-e' option.
> 
> Signed-off-by: Lucas Mateus Castro(alqotel) <lucas.araujo@eldorado.org.br>
> ---
>   tests/docker/dockerfiles/alpine.docker | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/docker/dockerfiles/alpine.docker b/tests/docker/dockerfiles/alpine.docker
> index 3f4c0f95cb..2943a99730 100644
> --- a/tests/docker/dockerfiles/alpine.docker
> +++ b/tests/docker/dockerfiles/alpine.docker
> @@ -21,6 +21,7 @@ RUN apk update && \
>           cdrkit \
>           ceph-dev \
>           clang \
> +        coreutils \
>           ctags \
>           curl-dev \
>           cyrus-sasl-dev \

Not a good idea. If you look at the top of the file, you can see:

# THIS FILE WAS AUTO-GENERATED

So your modifications will be overwritten the next time someone runs the 
lcitool.

I guess you'd need to modify tests/lcitool/projects/qemu.yml instead? Daniel?

Anyway, it might be better to fix the part that uses "readlink -e" ... Seems 
like busybox' readlink supports -f at least, so maybe it's enough to switch 
to -f instead of -e ?

  Thomas