Re: [PATCH v2 4/4] net: macb: enable mii on rgmii for sama7g5

From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Claudiu Beznea <claudiu.beznea@microchip.com>,
	<davem@davemloft.net>, <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] net: macb: enable mii on rgmii for sama7g5
Date: Fri, 17 Sep 2021 15:33:47 +0200	[thread overview]
Message-ID: <216f6e40-0faa-027a-6a73-e516a02bb21b@microchip.com> (raw)
In-Reply-To: <20210917132615.16183-5-claudiu.beznea@microchip.com>

On 17/09/2021 at 15:26, Claudiu Beznea wrote:
> Both MAC IPs available on SAMA7G5 support MII on RGMII feature.
> Enable these by adding proper capability to proper macb_config
> objects.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

Yes:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Thanks Claudiu, best regards,
   Nicolas

> ---
>   drivers/net/ethernet/cadence/macb_main.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index cdf3e35b5b33..e2730b3e1a57 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -4597,7 +4597,8 @@ static const struct macb_config zynq_config = {
>   };
>   
>   static const struct macb_config sama7g5_gem_config = {
> -	.caps = MACB_CAPS_GIGABIT_MODE_AVAILABLE | MACB_CAPS_CLK_HW_CHG,
> +	.caps = MACB_CAPS_GIGABIT_MODE_AVAILABLE | MACB_CAPS_CLK_HW_CHG |
> +		MACB_CAPS_MIIONRGMII,
>   	.dma_burst_length = 16,
>   	.clk_init = macb_clk_init,
>   	.init = macb_init,
> @@ -4605,7 +4606,8 @@ static const struct macb_config sama7g5_gem_config = {
>   };
>   
>   static const struct macb_config sama7g5_emac_config = {
> -	.caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII | MACB_CAPS_USRIO_HAS_CLKEN,
> +	.caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII |
> +		MACB_CAPS_USRIO_HAS_CLKEN | MACB_CAPS_MIIONRGMII,
>   	.dma_burst_length = 16,
>   	.clk_init = macb_clk_init,
>   	.init = macb_init,
> 


-- 
Nicolas Ferre