From: Sricharan Ramabadhran <quic_srichara@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <srinivas.kandagatla@linaro.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <thara.gopinath@gmail.com>,
<rafael@kernel.org>, <daniel.lezcano@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<dmitry.baryshkov@linaro.org>,
Sricharan R <quic_srichara@quicinc.com>
Subject: Re: [PATCH V3 1/4] dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible
Date: Mon, 25 Sep 2023 07:36:36 +0530 [thread overview]
Message-ID: <21caae64-b8db-ed1f-2275-a7279227cf92@quicinc.com> (raw)
In-Reply-To: <f4fa94ab-78fb-d01b-7188-c498ec3053ff@linaro.org>
On 9/23/2023 5:14 PM, Krzysztof Kozlowski wrote:
> On 22/09/2023 13:51, Sricharan R wrote:
>> From: Sricharan Ramabadhran <quic_srichara@quicinc.com>
>>
>> IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt.
>
> Then why do you allow two interrupts?
>
infact there is only one interrupt. Will fix in the binding
description.
>>
>> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
>> ---
>> [v3] Added the tsens-ipq5018 as new binding without rpm
>>
>> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> index 27e9e16e6455..a02829deeb24 100644
>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> @@ -44,6 +44,10 @@ properties:
>> - qcom,qcs404-tsens
>> - const: qcom,tsens-v1
>>
>> + - description: v1 of TSENS without rpm
>> + enum:
>> + - qcom,ipq5018-tsens
>
> You miss now description of interrupts, like the other variants have.
>
ok, will add it.
Regards,
Sricharan
next prev parent reply other threads:[~2023-09-25 2:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 11:51 [PATCH V3 0/4] Add support for IPQ5018 tsens Sricharan R
2023-09-22 11:51 ` [PATCH V3 1/4] dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible Sricharan R
2023-09-22 20:50 ` Rob Herring
2023-09-23 11:44 ` Krzysztof Kozlowski
2023-09-25 2:06 ` Sricharan Ramabadhran [this message]
2023-09-25 6:46 ` Krzysztof Kozlowski
2023-09-25 10:31 ` Sricharan Ramabadhran
2023-09-25 10:40 ` Krzysztof Kozlowski
2023-09-22 11:51 ` [PATCH V3 2/4] thermal/drivers/qcom: Add new feat for soc without rpm Sricharan R
2023-09-22 11:51 ` [PATCH V3 3/4] thermal/drivers/tsens: Add support for IPQ5018 tsens Sricharan R
2023-09-23 18:46 ` Dmitry Baryshkov
2023-10-04 19:07 ` Robert Marko
2023-10-17 13:08 ` Sricharan Ramabadhran
2023-09-22 11:51 ` [PATCH V3 4/4] arm64: dts: qcom: ipq5018: Add tsens node Sricharan R
2023-09-23 18:48 ` Dmitry Baryshkov
2023-09-25 2:09 ` Sricharan Ramabadhran
2023-10-04 19:08 ` Robert Marko
2023-10-17 13:07 ` Sricharan Ramabadhran
2023-10-17 13:13 ` Robert Marko
2023-11-03 8:11 ` Sricharan Ramabadhran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21caae64-b8db-ed1f-2275-a7279227cf92@quicinc.com \
--to=quic_srichara@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.