Re: [Intel-gfx] [PATCH 2/7] drm: delay vblank cleanup until after driver unload

From: Dave Airlie <airlied@gmail.com>
To: "Kristian Høgsberg" <krh@bitplanet.net>
Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.sourceforge.net,
	Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [Intel-gfx] [PATCH 2/7] drm: delay vblank cleanup until after driver unload
Date: Mon, 29 Mar 2010 10:09:42 +1000	[thread overview]
Message-ID: <21d7e9971003281709m722379a7gb397b41195811197@mail.gmail.com> (raw)
In-Reply-To: <21d7e9971003281702kf766c0fk486f55c84f3416a@mail.gmail.com>

2010/3/29 Dave Airlie <airlied@gmail.com>:
> 2010/3/29 Kristian Høgsberg <krh@bitplanet.net>:
>> On Fri, Mar 26, 2010 at 7:07 PM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>>> Drivers may use vblank calls now (e.g. drm_vblank_off) in their unload
>>> paths, so don't clean up the vblank related structures until after
>>> driver unload.
>>
>> I haven't tested this specific patch on a recent DRM, but I made the
>> same patch a while ago, and it fixed module unload for me.  I sent it
>> to the list and it fell through the cracks, because "vblank is hard"
>> or something.
>>
>> Reviewed-by: Kristian Høgsberg <krh@bitplanet.net>
>
> I didn't apply it because from what I can see non-kms drivers need
> to free the vbl stuff on lastclose not unload. I'm nearly sure I said
> that at the
> time to.
>
> This patch seems to suffer from the same problem from what I can see.
>
> And really someone should already have cleaned up the insanity that is vbl
> struct allocations, vblank might not be hard, but it sure has some ugly.

Oops on reading it makes more sense, I thought we were moving it from lastclose,
my bad, too little sleep.

Okay I'll push it in next push.

Dave.

>
> Dave.
>

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--