From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Carl Smedstad <carl.smedstad@protonmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] check-ignore: --non-matching without --verbose
Date: Tue, 24 May 2022 21:26:30 +0200 [thread overview]
Message-ID: <220524.868rqqwx1t.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqwneahh8t.fsf@gitster.g>
On Tue, May 24 2022, Junio C Hamano wrote:
> Carl Smedstad <carl.smedstad@protonmail.com> writes:
>
>>> Not commenting on the patch itself, but ...
>>>
>>> > find . |
>>> > git check-ignore --verbose --non-matching |
>>> > grep $'^::\t' |
>>> > sed -e 's/.*\t//'
>>>
>>> ... feeding grep output to sed caught my eyes. Isn't that equivalent to
>>>
>>> git ... |
>>> sed -n '/^::\t/s/.*\t//p'
>>
>> That is indeed equivalent. TIL about regular-expression addresses in
>> sed, thanks!
>
> I however suspect that these "\t"'s should be spelled out as an
> actual TAB in the final production version for portability.
Make that a "for sure", it's a commonly unsupported feature of some
sed's, it's actually more common that not that it isn't supported. See
$HT in t4213-log-tabexpand.sh.
next prev parent reply other threads:[~2022-05-24 19:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 12:54 [PATCH] check-ignore: --non-matching without --verbose Carl Smedstad via GitGitGadget
2022-05-23 18:14 ` Junio C Hamano
2022-05-24 13:03 ` Carl Smedstad
2022-05-24 19:18 ` Junio C Hamano
2022-05-24 19:26 ` Ævar Arnfjörð Bjarmason [this message]
2022-05-23 20:44 ` Derrick Stolee
2022-05-24 13:06 ` Carl Smedstad
2022-05-24 13:01 ` [PATCH v2] " Carl Smedstad via GitGitGadget
2022-05-24 17:45 ` [PATCH] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220524.868rqqwx1t.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=carl.smedstad@protonmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.