From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: andrew.cooper3@citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v2] xl: close nullfd after dup2'ing it to stdin
Date: Tue, 1 Mar 2016 13:40:08 +0000 [thread overview]
Message-ID: <22229.39864.274755.910691@mariner.uk.xensource.com> (raw)
In-Reply-To: <1455705580-27781-1-git-send-email-ian.campbell@citrix.com>
Ian Campbell writes ("[PATCH v2] xl: close nullfd after dup2'ing it to stdin"):
> We assert that nullfd if not std{in,out,err} since that would result
> in closing one of the just dup2'd fds. For this to happen
> std{in,out,err} would have needed to be closed, at which point all
> sorts of other things could go wrong.
>
> CID: 1130519
>
> It was previously hypothesised[0] that fixing 1130516 would solve this
> too, but that appears to not have been the case.
>
> Compile tested only.
>
> [0] http://lists.xenproject.org/archives/html/xen-devel/2013-11/msg02931.html
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Cc: andrew.cooper3@citrix.com
> ---
> v2: Assert logfile and nullfd are not stdio fds
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
(The copy to ijc may bounce I guess...)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-03-01 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 11:35 [PATCH] xl: close nullfd after dup2'ing it to stdin Ian Campbell
2016-02-16 13:06 ` Wei Liu
2016-02-16 17:45 ` Ian Jackson
2016-02-16 21:54 ` Ian Campbell
2016-02-17 10:39 ` [PATCH v2] " Ian Campbell
2016-02-23 10:30 ` Ian Campbell
2016-02-29 15:45 ` Konrad Rzeszutek Wilk
2016-03-01 12:54 ` Wei Liu
2016-03-01 13:40 ` Ian Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22229.39864.274755.910691@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.