From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] [[for-4.7]] libxl: fix old style declarations
Date: Wed, 20 Apr 2016 14:35:29 +0100 [thread overview]
Message-ID: <22295.34209.255696.256971@mariner.uk.xensource.com> (raw)
In-Reply-To: <1460932613-10522-1-git-send-email-wei.liu2@citrix.com>
Wei Liu writes ("[PATCH] [[for-4.7]] libxl: fix old style declarations"):
> Fix errors like:
>
> /local/work/xen.git/dist/install/usr/local/include/libxl_uuid.h:59:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
> void static inline libxl_uuid_copy_0x040400(libxl_uuid *dst,
> ^
> /local/work/xen.git/dist/install/usr/local/include/libxl_uuid.h:59:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration]
>
> /local/work/xen.git/dist/install/usr/local/include/libxl.h:1233:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
> int static inline libxl_domain_create_restore_0x040200(
> ^
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Thanks,
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
and queued with your release ack as discussed on irc.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-04-20 13:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-17 22:36 [PATCH] libxl: fix old style declarations Wei Liu
2016-04-20 13:35 ` Ian Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22295.34209.255696.256971@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.