From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH v2] tools: detect appropriate debug optimization level
Date: Fri, 22 Apr 2016 17:08:41 +0100 [thread overview]
Message-ID: <22298.19593.594867.213667@mariner.uk.xensource.com> (raw)
In-Reply-To: <1461077836-7735-1-git-send-email-cardoe@cardoe.com>
Doug Goldstein writes ("[PATCH v2] tools: detect appropriate debug optimization level"):
> When building debug use -Og as the optimization level if its available,
> otherwise retain the use of -O0. -Og has been added by GCC to enable all
> optimizations that to not affect debugging while retaining full
> debugability.
...
> -CFLAGS += -O0 -g3
> +CFLAGS += $(call cc-option,$(CC),-Og,-O0)
> +CFLAGS += -g3
I think CFLAGS is a variable which is expanded late, at each reference
site - a `recursively expanded' variable.
The result is that the call to the compiler to test the -Og flag
(implied by cc-option) will be executed potentially for every C source
code file!
I think you need to use cc-option-add.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-04-22 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 14:57 [PATCH v2] tools: detect appropriate debug optimization level Doug Goldstein
2016-04-22 16:08 ` Ian Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22298.19593.594867.213667@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=cardoe@cardoe.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.