From: Ian Jackson <ian.jackson@eu.citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
George Dunlap <dunlapg@umich.edu>
Subject: Re: [PATCH qemu-xen-traditional 1/2] xen_platform: unplug also SCSI disks [and 1 more messages]
Date: Tue, 31 Jan 2017 17:32:18 +0000 [thread overview]
Message-ID: <22672.51746.179183.6106@mariner.uk.xensource.com> (raw)
In-Reply-To: <20170131171417.GB20351@aepfle.de>
Olaf Hering writes ("Re: [Xen-devel] [PATCH qemu-xen-traditional 1/2] xen_platform: unplug also SCSI disks [and 1 more messages]"):
> So what should be done with the two patches?
> Are they acceptable for staging, or will they be rejected?
I am happy with the first patch, as I say. Would you like me to apply
it while we discuss the 2nd ?
As for the 2nd patch: the last new feature was added to qemu-xen in
late 2011 ("qemu-xen: add vkbd support for PV on HVM guests"
9b33a3e5603e) or maybe early 2012 ("xen: introduce an event channel
for buffered io event notifications" a5af89a7d40d).
You are asking for a new feature to be accepted in a codebase which
has been on receiving only security fixes and bitrot fixes for many
years.
AFAICT it seems unlikely that this new feature will add new security
bugs, but might it break some old guests which mistakenly write to
this ioport ?
I think if you can reassure me about this point, I may be persuaded to
accept the patch.
Very sorry to be so awkward.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-01-31 17:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 20:11 [PATCH qemu-xen-traditional 0/2] Xen HVM unplug changes Olaf Hering
2016-11-24 20:11 ` [PATCH qemu-xen-traditional 1/2] xen_platform: unplug also SCSI disks Olaf Hering
2017-01-09 14:34 ` [PATCH qemu-xen-traditional 1/2] xen_platform: unplug also SCSI disks [and 1 more messages] Ian Jackson
2017-01-09 16:39 ` Olaf Hering
2017-01-10 10:34 ` George Dunlap
2017-01-31 17:14 ` Olaf Hering
2017-01-31 17:32 ` Ian Jackson [this message]
2017-01-31 17:44 ` Olaf Hering
2016-11-24 20:11 ` [PATCH qemu-xen-traditional 2/2] xen_platform: SUSE xenlinux unplug for emulated PCI Olaf Hering
2017-01-09 11:23 ` [PATCH qemu-xen-traditional 0/2] Xen HVM unplug changes Olaf Hering
2017-01-09 14:26 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22672.51746.179183.6106@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=dunlapg@umich.edu \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.