Re: [PULL 00/16] migration queue

From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>,
	yubihong@huawei.com, peterx@redhat.com, peter.maydell@linaro.org,
	quintela@redhat.com
Subject: Re: [PULL 00/16] migration queue
Date: Sat, 31 Oct 2020 17:12:20 +0100	[thread overview]
Message-ID: <2333379.eghUmhzIt0@silver> (raw)
In-Reply-To: <20201026161952.149188-1-dgilbert@redhat.com>

On Montag, 26. Oktober 2020 17:19:36 CET Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> The following changes since commit a46e72710566eea0f90f9c673a0f02da0064acce:
> 
>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20201026' into
> staging (2020-10-26 14:50:03 +0000)
> 
> are available in the Git repository at:
> 
>   git://github.com/dagrh/qemu.git tags/pull-migration-20201026a
> 
> for you to fetch changes up to a47295014de56e108f359ec859d5499b851f62b8:
> 
>   migration-test: Only hide error if !QTEST_LOG (2020-10-26 16:15:04 +0000)
> 
> ----------------------------------------------------------------
> migration pull: 2020-10-26
> 
> Another go at Peter's postcopy fixes
> 
> Cleanups from Bihong Yu and Peter Maydell.
> 
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> 

May it be possible that this PR introduced a lockup of the qtests that I am 
encountering in this week's upstream revisions?

PASS 25 qtest-x86_64/bios-tables-test /x86_64/acpi/microvm/pcie

Looking for expected file 'tests/data/acpi/microvm/FACP.rtc'
Looking for expected file 'tests/data/acpi/microvm/FACP'
Using expected file 'tests/data/acpi/microvm/FACP'
Looking for expected file 'tests/data/acpi/microvm/APIC.rtc'
Looking for expected file 'tests/data/acpi/microvm/APIC'
Using expected file 'tests/data/acpi/microvm/APIC'
Looking for expected file 'tests/data/acpi/microvm/DSDT.rtc'
Using expected file 'tests/data/acpi/microvm/DSDT.rtc'
PASS 24 qtest-i386/bios-tables-test /i386/acpi/microvm/rtc
PASS 15 qtest-i386/migration-test /i386/migration/multifd/tcp/cancel
PASS 16 qtest-i386/migration-test /i386/migration/multifd/tcp/zlib
^Cmake: *** [Makefile.mtest:1169: run-test-144] Interrupt

I tried to bisect the causing commit and came up to this PR merge. But I'm not 
absolutely sure it really is, because it sometimes takes 2 hours or more to 
trigger the lockup, so the relevant commit may as well have slipped during 
bisection.

Last week's revisions run here for >24h without issues, right now I get 
lockups of test runs after ~3min .. ~2h when running the qtests in an endless 
loop:

#/bin/sh
i=0
while true; do
  i=$[$i+1]
  echo '**************************************************'
  echo "* RUN $i                                         *"
  echo '**************************************************'
  make check-qtest -j32 V=1
  if [[ "$?" -ne 0 ]]; then
    echo "Aborted after $i runs due to failure"
    break
  fi
done

> ----------------------------------------------------------------
> Bihong Yu (9):
>       migration: Do not use C99 // comments
>       migration: Don't use '#' flag of printf format
>       migration: Add spaces around operator
>       migration: Open brace '{' following struct go on the same line
>       migration: Add braces {} for if statement
>       migration: Do not initialise statics and globals to 0 or NULL
>       migration: Open brace '{' following function declarations go on the
> next line migration: Delete redundant spaces
>       migration: using trace_ to replace DPRINTF
> 
> Peter Maydell (1):
>       migration: Drop unused VMSTATE_FLOAT64 support
> 
> Peter Xu (6):
>       migration: Pass incoming state into qemu_ufd_copy_ioctl()
>       migration: Introduce migrate_send_rp_message_req_pages()
>       migration: Maintain postcopy faulted addresses
>       migration: Sync requested pages after postcopy recovery
>       migration/postcopy: Release fd before going into 'postcopy-pause'
>       migration-test: Only hide error if !QTEST_LOG
> 
>  include/migration/vmstate.h  | 13 ----------
>  migration/block.c            | 40 ++++++++++++++---------------
>  migration/migration.c        | 59
> +++++++++++++++++++++++++++++++++++++----- migration/migration.h        |
> 24 ++++++++++++++---
>  migration/page_cache.c       | 13 +++-------
>  migration/postcopy-ram.c     | 27 +++++++++++++++-----
>  migration/ram.c              | 14 +++++-----
>  migration/rdma.c             |  7 ++---
>  migration/savevm.c           | 61
> ++++++++++++++++++++++++++++++++++++++++++-- migration/trace-events       |
> 16 ++++++++++++
>  migration/vmstate-types.c    | 26 -------------------
>  migration/vmstate.c          | 10 ++++----
>  tests/qtest/migration-test.c |  6 ++++-
>  13 files changed, 213 insertions(+), 103 deletions(-)