From: Ian Jackson <ian.jackson@citrix.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: "Jürgen Groß" <jgross@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Wei Liu" <wl@xen.org>
Subject: Re: [Xen-devel] [XEN PATCH for-4.13 5/6] libxl: Move shadow_memkb and iommu_memkb defaulting into libxl
Date: Fri, 4 Oct 2019 18:23:42 +0100 [thread overview]
Message-ID: <23959.32798.263057.440385@mariner.uk.xensource.com> (raw)
In-Reply-To: <20191004171928.GO1163@perard.uk.xensource.com>
Anthony PERARD writes ("Re: [XEN PATCH for-4.13 5/6] libxl: Move shadow_memkb and iommu_memkb defaulting into libxl"):
> On Fri, Oct 04, 2019 at 04:17:06PM +0100, Ian Jackson wrote:
> > @@ -862,6 +864,30 @@ static void domcreate_destruction_cb(libxl__egc *egc,
> > libxl__domain_destroy_state *dds,
> > int rc);
> >
> > +static _Bool ok_to_default_memkb_in_create(libxl__gc *gc)
>
> Is there a reason to use _Bool instead of `bool'? It would be the first
> _Bool in libxl.
I had the wrong head on. (I've been writing code recently where
`bool' wasn't available.)
> > + return CTX->libxl_domain_need_memory_0x041200_called &&
> > + !CTX->libxl_domain_need_memory_called;
>
> I think the logic here is inverted.
You are right.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-04 17:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 15:17 [Xen-devel] [XEN PATCH for-4.13 0/6] Drop/deprecate libxl_get_required_*_memory Ian Jackson
2019-10-04 15:17 ` [Xen-devel] [XEN PATCH for-4.13 1/6] libxl: Offer API versions 0x040700 and 0x040800 Ian Jackson
2019-10-04 15:33 ` Anthony PERARD
2019-10-04 16:08 ` Ian Jackson
2019-10-04 15:17 ` [Xen-devel] [XEN PATCH for-4.13 2/6] xl: Pass libxl_domain_config to freemem(), instead of b_info Ian Jackson
2019-10-04 17:24 ` Anthony PERARD
2019-10-04 15:17 ` [Xen-devel] [XEN PATCH for-4.13 3/6] libxl: libxl__domain_config_setdefault: New function Ian Jackson
2019-10-04 15:53 ` Anthony PERARD
2019-10-04 16:04 ` Ian Jackson
2019-10-04 17:25 ` Anthony PERARD
2019-10-07 9:57 ` Ian Jackson
2019-10-04 15:17 ` [Xen-devel] [XEN PATCH for-4.13 4/6] libxl: libxl_domain_need_memory: Make it take a domain_config Ian Jackson
2019-10-04 16:19 ` Anthony PERARD
2019-10-04 15:17 ` [Xen-devel] [XEN PATCH for-4.13 5/6] libxl: Move shadow_memkb and iommu_memkb defaulting into libxl Ian Jackson
2019-10-04 17:19 ` Anthony PERARD
2019-10-04 17:23 ` Ian Jackson [this message]
2019-10-04 15:17 ` [Xen-devel] [XEN PATCH for-4.13 6/6] libxl: Remove/deprecate libxl_get_required_*_memory from the API Ian Jackson
2019-10-04 17:24 ` Anthony PERARD
2019-10-07 6:45 ` [Xen-devel] [XEN PATCH for-4.13 0/6] Drop/deprecate libxl_get_required_*_memory Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23959.32798.263057.440385@mariner.uk.xensource.com \
--to=ian.jackson@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=jgross@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.