From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: linux-clk@vger.kernel.org, tomasz.figa@gmail.com,
sboyd@codeaurora.org, mturquette@baylibre.com, kgene@kernel.org,
b.zolnierkie@samsung.com, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 5/5] clk: samsung: Add support for exynos5410 AUDSS clock controller
Date: Fri, 02 Sep 2016 17:19:42 +0200 [thread overview]
Message-ID: <23ed1cb9-8219-777f-c42c-32d8ae404650@samsung.com> (raw)
In-Reply-To: <94535e9f-7c13-8be2-3bdf-8c3d3354c688@samsung.com>
On 08/30/2016 12:38 PM, Krzysztof Kozlowski wrote:
> On 08/22/2016 06:31 PM, Sylwester Nawrocki wrote:
>> > Exynos5410 Audio Subsystem Clock Controller, comparing to the already
>> > supported by the driver IP block revisions, has additionally an I2S_MST
>> > divider so a new compatible string is added.
>> > While at it, the variant handling is reworked to avoid scattered testing
>> > for the controller's variant.
>
> Please split it into simple changes:
> 1. Whitespace cleanup (below you do it).
> 2. Variant handling rework.
> 3. New compatible added.
>
> This would make easy to spot changes and new features.
Ok, I'll split it, thanks for your review.
prev parent reply other threads:[~2016-09-02 15:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 16:30 [PATCH 0/5] clk/samsung: Add support for PDMA, EPLL clocks on exynos5410 Sylwester Nawrocki
2016-08-22 16:30 ` [PATCH 1/5] clk: samsung: exynos5410: Add clock IDs for PDMA and EPLL clocks Sylwester Nawrocki
2016-08-30 9:54 ` Krzysztof Kozlowski
2016-09-02 14:09 ` Sylwester Nawrocki
2016-09-02 17:36 ` Krzysztof Kozlowski
2016-08-22 16:31 ` [PATCH 2/5] clk: samsung: exynos5410: Expose the peripheral DMA gate clocks Sylwester Nawrocki
2016-08-30 9:56 ` Krzysztof Kozlowski
2016-08-22 16:31 ` [PATCH 3/5] clk: samsung: Use common registration function for pll2550x Sylwester Nawrocki
2016-08-30 10:13 ` Krzysztof Kozlowski
2016-08-22 16:31 ` [PATCH 4/5] clk: samsung: Add support for EPLL on exynos5410 Sylwester Nawrocki
2016-08-30 10:36 ` Krzysztof Kozlowski
2016-09-02 15:15 ` Sylwester Nawrocki
2016-09-02 17:32 ` Krzysztof Kozlowski
2016-09-05 7:48 ` Sylwester Nawrocki
2016-08-22 16:31 ` [PATCH 5/5] clk: samsung: Add support for exynos5410 AUDSS clock controller Sylwester Nawrocki
2016-08-30 10:38 ` Krzysztof Kozlowski
2016-09-02 15:19 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23ed1cb9-8219-777f-c42c-32d8ae404650@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.