From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Markus Reichl <m.reichl@fivetechno.de>
Subject: Re: [PATCH] ARM: dts: exynos: Remove 'opp-shared' from Exynos4412 bus OPP-tables
Date: Fri, 2 Oct 2020 08:00:28 +0200 [thread overview]
Message-ID: <2414d856-0861-36a9-cd27-a684eb3447fb@samsung.com> (raw)
In-Reply-To: <20200920152738.GA7451@kozik-lap>
Hi Krzysztof,
On 20.09.2020 17:27, Krzysztof Kozlowski wrote:
> On Fri, Sep 11, 2020 at 02:22:36PM +0200, Marek Szyprowski wrote:
>> Commits 1019fe2c7280 ("ARM: dts: exynos: Adjust bus related OPPs to the
>> values correct for Exynos5422 Odroids") and 9ff416cf45a0 ("ARM: dts:
>> exynos: Disable frequency scaling for FSYS bus on Odroid XU3 family")
>> revealed that 'opp-shared' property for the Exynos bus OPPs was used
>> incorrectly, what had the side-effect of disabling frequency scaling for
>> the second and latter buses sharing given OPP-table.
>>
>> Fix this by removing bogus 'opp-shared' properties from Exynos4412 bus
>> OPP-tables. This restores frequency scaling for the following busses:
>> C2C, RightBus, and MFC.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos4412.dtsi | 6 ------
>> 1 file changed, 6 deletions(-)
>>
> As discussed on IRC, I am waiting with these patches till you let me
> know they're good.
I got the information from Markus Reichl that this patch finally doesn't
cause a regression. The issue he observed must be something else.
Anyway, I would like to postpone this patch to the next release cycle to
give it enough testing in linux-next.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2020-10-02 6:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200911122246eucas1p1a8ccc7c5b970ce6aa9aa346d78ad69df@eucas1p1.samsung.com>
2020-09-11 12:22 ` [PATCH] ARM: dts: exynos: Remove 'opp-shared' from Exynos4412 bus OPP-tables Marek Szyprowski
2020-09-20 15:27 ` Krzysztof Kozlowski
2020-10-02 6:00 ` Marek Szyprowski [this message]
2020-10-02 6:10 ` Krzysztof Kozlowski
2020-10-27 17:43 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2414d856-0861-36a9-cd27-a684eb3447fb@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.reichl@fivetechno.de \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.